Introduces 'path' as an alternative to 'raster_path' with a deprecation warning #569
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bw4sz
requested changes
Dec 8, 2023
So are the changes enough or any more changes needed? |
henrykironde
reviewed
Feb 5, 2024
| "The 'raster_path' argument is deprecated and will be removed in future versions. Use 'path' instead.", | ||
| DeprecationWarning | ||
| ) | ||
| path = raster_path |
There was a problem hiding this comment.
Where are we using this value path?
Abhishek-kumar0503
added a commit
to Abhishek-kumar0503/DeepForest
that referenced
this pull request
Mar 5, 2024
…ter_path' with a deprecation warning
|
Thanks for the contribution @manascb1344. I'm going to close this PR in favor of #617 since this one just adds the argument but doesn't make all of the downstream changes to make that new argument work. Those changes are all completed in #617 if you want to see a complete set of changes for this issue looks like. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.