Improve point plotting behavior for ground truth with no scores. #879
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… if no scores are present.
|
Looks like there's a style error that needs fixing before merge |
|
Thanks. Just waiting on the tests |
|
Docs error is independent |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current behavior fails if you have ground truth that don't have a 'scores' column. Which makes no sense, since ground truth don't have confidence scores, from the model atleast. This behavior was already fixed for boxes and polygons. I added a try except, added a dummy 1 for scores in the dataframe just within the plotting function, and added a test.