-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
v0.9.0 #129
Merged
Merged
v0.9.0 #129
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
unnecessary for that function
functions included now are for creating the directory and downloading files, as well as some utilities all of the functions that haven't been generalized fully have been pulled out for the time being to help ensure a non-vestigial codebase
including fill_raw to work generally
its creating an unnecessary level of coding. keeping it simple with base, main, and subs arguments next step might actually combine the base and main tho
no longer do we need to have base explicitly in the code the main input can be used to root the directory and make any additional hierarchy
starting to flesh this setup out
write_model model_names model_script_controls also removed the internal data object for now
i think that's what's causing the note re: check-level folders
to minimize runtimes
This was referenced Sep 4, 2019
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Major API update: increase in explicit top-level arguments
setup
functions, in particularsetup_sandbox
. addressesmodel_names
functions when you need to (usually in coding inside of functions or for setting default argument levels). addressesDirectory tree structure simplified
dirtree
was removedbase
(both as a function and a concept) was removed. To make that structure use main = "./name"Tightened messaging
quiet
andverbose
connected throughout the pipeline.Download capacity generalized
download
function. addresses and addresses and addressesChanges for users adding their own models to the prefab set
portalcast
and it will run it with everything else.model_script_controls
rather than write their own control functions.prefab_models
script (reusing and adding to the documentation inprefab_model_functions
), rather than to its own script.model_names
.Relaxed model requirements
More organization via metadata
dir_config.yaml
file, which is pulled from to save information about what was used to create, setup, and run the particular casts.Changes for users interested in analyzing their own data sets not in the standard data set configuration
data_sets
argument and the controls defining the data set (used by portalr'ssummarize_rodent_data
function) in thecontrols_rodents
argument.arg_checks = FALSE
in the relevant function).rodents_controls
function, just like with the models.control_files
(seefile_controls
) input list, which allows for some general flexibility with respect to what files the pipeline is reading in from thedata
subdirectory.Split of standard data sets
all
andcontrols
were both default being interpolated for all models because of the use of AIC for model comparison and ensemble building. That forced all models to use interpolated data.Application of specific models to specific data sets now facilitated
write_model
andmodel_template
have adata_sets
argument that is used to write the code out, replacing the hard code requirement of analyzing "all" and "controls" for every model. Now, users who wish to analyze a particular data component can easily add it to the analysis pipeline.Generalization of code terms
start_newmoon
is nowstart_moon
likeend_moon
"Hindcasting" becomes more similar to "forecasting"
end_moon
) that is not the most recently occurring moon.cast_type
is retained in the metadata file for posterity, but functionality is more generally checked by consideringend_moon
andlast_moon
in combination, whereend_moon
is the forecast origin andlast_moon
is the most recentcast_type
has been removed as an input, it's auto determined now based onend_moon
and the last moon available (if they're equal it's a "forecast", if not it's a "hindcast").Softer handling of model failure
cast
, the model scripts are now sourced within a for-loop (rather than sapply) to allow for simple error catching of each script. addressesImproved argument checking flow
arg_checks
logical argument that goes intocheck_args
to turn off all of the underlying code, enabling the user to go off the production restrictions that would otherwise through errors, even though they might technically work under the hood.Substantial re-writes of the vignettes
adding a model or data
vignette into "working locally" and "adding to the pipeline", also added checklists and screen shots. addressesgetting started
vignette to an order that makes sense. addressesPost-processing (evaluation and ensemble building) temporarily removed
Additional things
drop_spp
is now changed tospecies
(so focus on inclusion, not exclusion). addresses\donttest{}
. addressesskip_on_cran
used judiciously. addresses