Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

v0.13.0 #155

Merged
merged 3 commits into from
Oct 13, 2019
Merged

v0.13.0 #155

merged 3 commits into from
Oct 13, 2019

Conversation

juniperlsimonis
Copy link
Member

Full writing of control_files in model scripts

  • Previously, the controls list for the files in the model scripts was taken from the environment in which the script was run, which opens the script to everything, which is undesirable.
  • After the need to include a control list for runjags models forced an explicit writing of the list inputs, the code was available to transfer to the files control list.
  • This does mean that the function calls in the scripts are now super long and explicit, but that's ok.
  • To avoid super long model script lines (where event default inputs are repeated in the list functions), a function control_list_arg was made to generalize what was coded up from the runjags list for use also with the files control list. This function writes a script component that only includes arguments to the list function that are different from the formal definition.

### Full writing of `control_files` in model scripts
* Previously, the controls list for the files in the model scripts was taken from the environment in which the script was run, which opens the script to everything, which is undesirable.
* After the need to include a control list for runjags models forced an explicit writing of the list inputs, the code was available to transfer to the files control list.
* This does mean that the function calls in the scripts are now super long and explicit, but that's ok.
* To avoid super long model script lines (where event default inputs are repeated in the list functions), a function `control_list_arg` was made to generalize what was coded up from the runjags list for use also with the files control list. This function writes a script component that only includes arguments to the list function that are different from the formal definition.
@juniperlsimonis juniperlsimonis merged commit 8bc504d into master Oct 13, 2019
PrayasJ pushed a commit to PrayasJ/portalcasting that referenced this pull request Aug 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant