Fixing the build script as recommended

weiznich · Apr 21, 2022 · e548324 · e548324
1 parent 2e8fe7a
commit e548324
Show file tree

Hide file tree

Showing 3 changed files with 4 additions and 11 deletions.
diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml
@@ -287,7 +287,7 @@ jobs:
         uses: actions-rs/cargo@v1
         with:
           command: test
-          args: --manifest-path diesel_dynamic_schema/Cargo.toml --no-default-features --features "${{ matrix.backend }}"
+          args: --manifest-path diesel_dynamic_schema/Cargo.toml --no-default-features --features "${{ matrix.backend }} diesel/${{ matrix.backend }}"
 
       - name: Run diesel_benches
         uses: actions-rs/cargo@v1
@@ -423,7 +423,6 @@ jobs:
           ASAN_OPTIONS: detect_stack_use_after_return=1
         run: cargo -Z build-std test --manifest-path diesel/Cargo.toml --no-default-features --features "sqlite extras libsqlite3-sys libsqlite3-sys/bundled libsqlite3-sys/with-asan" --target x86_64-unknown-linux-gnu
 
-
   minimal_rust_version:
     name: Check Minimal supported rust version (1.54.0)
     runs-on: ubuntu-latest

diff --git a/bin/test b/bin/test
@@ -26,23 +26,23 @@ else
   (cd diesel_migrations && cargo test --features "sqlite diesel/sqlite" $*)
   (cd diesel_derives && cargo test --features "diesel/sqlite" $*)
   (cd diesel_tests && cargo test --features "sqlite" --no-default-features $*)
-  (cd diesel_dynamic_schema && cargo test --features "sqlite" $*)
+  (cd diesel_dynamic_schema && cargo test --features "sqlite diesel/sqlite" $*)
   (cd diesel_bench && cargo test --features "sqlite" --benches $*)
 
   (cd diesel_migrations && cargo test --features "postgres diesel/postgres" $*)
   (cd diesel_migrations/migrations_macros && cargo test --features "diesel/postgres postgres" $*)
   (cd diesel_derives && cargo test --features "diesel/postgres" $*)
   (cd diesel_cli && cargo test --features "postgres" --no-default-features $*)
   (cd diesel_tests && cargo test --features "postgres" --no-default-features $*)
-  (cd diesel_dynamic_schema && cargo test --features "postgres" $*)
+  (cd diesel_dynamic_schema && cargo test --features "postgres diesel/postgres" $*)
   (cd diesel_bench && cargo test --features "postgres" --benches $*)
 
   (cd diesel_migrations && cargo test --features "mysql diesel/mysql" $* -- --test-threads 1)
   (cd diesel_migrations/migrations_macros && cargo test --features "diesel/mysql mysql" $* -- --test-threads 1)
   (cd diesel_derives && cargo test --features "diesel/mysql" $* -- --test-threads 1)
   (cd diesel_cli && cargo test --features "mysql" --no-default-features $* -- --test-threads 1)
   (cd diesel_tests && cargo test --features "mysql" --no-default-features $* -- --test-threads 1)
-  (cd diesel_dynamic_schema && cargo test --features "mysql" $* -- --test-threads 1)
+  (cd diesel_dynamic_schema && cargo test --features "mysql diesel/mysql" $* -- --test-threads 1)
   (cd diesel_bench && cargo test --features "mysql" --benches $* -- --test-threads 1)
 
   (cd diesel_compile_tests && cargo test $*)

diff --git a/diesel_dynamic_schema/Cargo.toml b/diesel_dynamic_schema/Cargo.toml
@@ -12,12 +12,6 @@ version = "2.0.0"
 path = "../diesel/"
 default-features = false
 
-[dev-dependencies.diesel]
-version = "2.0.0"
-path = "../diesel/"
-default-features = false
-features = ["postgres", "mysql"]
-
 [dev-dependencies]
 dotenvy = "0.15"