Fix how Lite extension translator distinguishes synthetic observers #2605
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
manovotn
reviewed
Dec 7, 2021
There was a problem hiding this comment.
Since getting a Bean from OM is now supported, we'll also need to implement it under ObserverInfoImpl, see https://github.com/weld/core/blob/master/weld-lite-extension-translator/src/main/java/org/jboss/weld/lite/extension/translator/ObserverInfoImpl.java#L77-L78
We can either do it in a temporary way (casting it impl-specific class), or wait until CDI API releases. I'd say we do it in Weld specific way for now so that we can get this merged.
|
I'd say this PR itself can be merged regardless, because it doesn't touch that code. Otherwise, I don't really mind. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.