remove withToggles #7300
Merged
remove withToggles #7300
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Lighthouse scores
|
|
Size Change: -776 B (0%) Total Size: 1.28 MB
ℹ️ View Unchanged
|
davidpmccormick
approved these changes
Nov 15, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removes withToggles, and all references to the odl toggles system 🍾
...
Alas, I've had to introduce a hack as api routes cannot us
fs- making the system we have no good for it. I thought we could have an async call out here to toggles, but I'd rather figure out a better way to maintain the rule of not calling out to a more services so whacked in a hack for now, and will try to figure out a way around it as part 2 of making the old toggles obsolete.For more on why it's designed this way: vercel/next.js#8251