-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Siqi_scratch #16
Merged
Merged
Siqi_scratch #16
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Open
Thank you so much, @iqis! I look forward to breaking this all down and examining your approach when I have more time. End-of-semester crunch time. :/ |
fix typos; add description and links
re-add if we retain her original code
Good to delete branch? And Audrey's and Amanda's? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@wendtke
I've taken a rather radical approach in modifying the code, please do bear with me. You don't need to merge everything from the pull request.
Before considering this pull request, I would suggest downloading this
siqi_scratch
branch, do a build on your own machine, and play around with it.You can try out the only function (so far) meant to be user-facing through the following:
This will return a list with three data frames:
EDA Stats
,SCR Stats
,Editing Stats
, and a named character vectorSettings
, corresponding to the four different sheets of the original Excel workbook.Please pay no regard to the warnings such as:
This comes from parsing the contents and will be turned off in the future.
In the attribute fields of the list, I also include
device_vendor
("MindWare"),origin_path
, andorigin_mtime
to document the file path and modified time for future use. I'm sure they will be helpful when the user constructs a study.You may also notice that I've taken a very modular approach in making the functions. I believe this is beneficial because when we expand the functionality of the package to more data types, we can have easily reusable parts. This is however, very opinionated, and I welcome a challenge from any angle.
Additionally, I shall note the following:
ro man
means generating manual pages for the functions with roxygen2.Thank you ~~~~~