fix bug #2162
Merged
fix bug #2162
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
manbaaaa
commented
Nov 24, 2023
manbaaaa
commented
- In order to accommodate 'whisper' and ensure compatibility, both RelPositionMultiHeadedAttention and MultiHeadedAttention require the 'key_bias' argument.
- If gradient accumulation is being used and the recorded train loss and cv loss in TensorBoard are not in the same order of magnitude, it might be beneficial to multiply the recorded train loss in TensorBoard by accum_grad as well for easier comparison.
|
plz fix lint |
done |
xingchensong
approved these changes
Nov 24, 2023
|
我发现旧的代码写tensorboard是没有* accumgrad的（v2.2.1, https://github.com/wenet-e2e/wenet/blob/v2.2.1/wenet/utils/executor.py#L89 ），比较的时候记得注意下,@manbaaaa |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.