Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[utils] align timeout between group_join and monitored_barrier #2270

Merged
merged 1 commit into from
Jan 2, 2024
Merged

[utils] align timeout between group_join and monitored_barrier #2270

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion wenet/utils/train_utils.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -425,7 +425,7 @@ def wenet_join(group_join, info_dict):
# operations are executed. If we add a communication operation that is not
# managed by Deepspeed in this group, it's highly likely to cause
# communication chaos, resulting in hard-to-troubleshoot hangs.
dist.monitored_barrier(group=group_join)
dist.monitored_barrier(group=group_join, timeout=group_join.options._timeout)
except RuntimeError as e:
logging.info("Detected uneven workload distribution: {}\n".format(e) +
"Break current worker to manually join all workers, " +
Expand Down
Loading