Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix APCU_BC pecl extension generating errors upon install #401

Merged
merged 2 commits into from
Aug 27, 2019

Conversation

Neodork
Copy link
Collaborator

@Neodork Neodork commented Aug 27, 2019

I have read the contribution guidelines and am targeting the branch 2.x because:
Because this is a Bug fix which is not backwards compatible.

Changelog entry:
Fixed installation bug with apcu_bc due to double .so directives getting placed in php.ini

Lou van der Laarse added 2 commits August 22, 2019 22:59
--------------------
Remove APCU_BC due to it generating errors. PECL APCU now supports PHP 7.0+ as of version 5.1.0.

https://pecl.php.net/package/APCu
@Neodork Neodork added 2.x Issues / features related the the 2.x branch MAJOR This change is major labels Aug 27, 2019
@Neodork
Copy link
Collaborator Author

Neodork commented Aug 27, 2019

This PR is tagged as Major but will be merged to 2.x due to the transition to 2.x. E.G: This is major from 1.0.x and thus candidate to be merged into 2.x instead of 3.x.

Just to clarify the violation of the contributors guidelines.

@Neodork
Copy link
Collaborator Author

Neodork commented Aug 27, 2019

Jobs failing on ioncube install for PHP 7.3.But passed the install. Merging.

@Neodork Neodork merged commit 3744bf5 into weprovide:2.x Aug 27, 2019
pathmissing pushed a commit to pathmissing/valet-plus that referenced this pull request Dec 4, 2019
)

* Fix APCU_BC generating errors
* Add upgrade file due to non-BC change

--------------------
Remove APCU_BC due to it generating errors. PECL `APC` now supports PHP 7.0+ as of version 5.1.0.

https://pecl.php.net/package/APCu
zelgerj added a commit to techdivision/valet-plus that referenced this pull request Dec 4, 2019
WIP: Fix APCU_BC pecl extension generating errors upon install (weprovide#401)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
2.x Issues / features related the the 2.x branch MAJOR This change is major
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant