Magerun binaries version bump #414
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@Igloczek How will we determine the shasum of the latest version? I think this will always fail. |
|
Damn, you are right, didn't saw that shasum in code 🙈 |
Igloczek
changed the title
|
@Igloczek This looks good. Can you squash your commits and target the |
|
@Neodork Done. |
binaries] Installing binaries
[binaries] magerun not found, installing from: https://files.magerun.net/n98-magerun-1.103.1.phar
% Total % Received % Xferd Average Speed Time Time Time Current
Dload Upload Total Spent Left Speed
0 0 0 0 0 0 0 0 --:--:-- --:--:-- --:--:-- 0
14 5383k 14 783k 0 0 1861k 0 0:00:02 --:--:-- 0:00:02 1861k
100 5383k 100 5383k 0 0 6470k 0 --:--:-- --:--:-- --:--:-- 6470k
[binaries] magerun installed to: /usr/local/bin/magerun
[binaries] magerun2 not found, installing from: https://files.magerun.net/n98-magerun2-3.2.0.phar
% Total % Received % Xferd Average Speed Time Time Time Current
Dload Upload Total Spent Left Speed
Looks good to me, merging. |
|
Changelog entries:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I had to manually update magerun2 binaries to make it compatible with M2.3.2 and saw that this issue can be easily fixed without any manual work just by always using the latest version.
As a bonus, you will not have to do a release of Valet to get some updates/fixes from Magerun.