Fix switching php versions not listening to error states

[Neodork]

• There is an issue ticket which accompanies my PR: Bug: valet switch does not stop when encountering error states #451.
• I have followed the guidelines for contributing.
• I have checked that there aren't other open pull requests for the same issue ticket.
• I have formatted my code with the PSR-2 coding style before submitting my PR.

---

I have read the contribution guidelines and am targeting the branch 2.x:
Because this is a Bug Fix which is Backwards Compatible.

Changelog entry:
Short description of your work as explained by: Keep A Changelog.

• Fixed bug where switching PHP version to a flawed installation would result in an unusable valet-plus installation.

[SanderAtom]

With this patch I could only break my installation because of an odd setup where I had a /usr/local/Cellar/[email protected]/7.2.24_2.reinstall folder left which was chosen by default when switching. After removing that I could not break the switching anymore. Removing 7.2 and switching to it displays the error and keeps the current php version linked as expected.

sander$ brew uninstall [email protected]
Uninstalling /usr/local/Cellar/[email protected]/7.2.24_2... (515 files, 75.0MB)
Error: Could not remove [email protected] keg! Do so manually:
  sudo rm -rf /usr/local/Cellar/[email protected]/7.2.24_2
sander$ sudo rm -rf /usr/local/Cellar/[email protected]/7.2.24_2
sander$ valet use 7.2
[[email protected]] Unlinking
Unlinking /usr/local/Cellar/[email protected]/7.3.2... 25 symlinks removed

[libjpeg] Relinking
[[email protected]] Linking
Linking /usr/local/Cellar/[email protected]/7.2.24_2.reinstall... 25 symlinks
[[email protected]] Stopping
[[email protected]] Stopping
[[email protected]] Stopping
[[email protected]] Stopping
[[email protected]] Stopping
[[email protected]] Stopping
[BREW TAP] henkrehorst/php already installed
PHP Warning:  file_get_contents(/usr/local/bin/pecl: line 28: /usr/local/Cellar/[email protected]/7.2.24_2/bin/php: No such file or directory/usr/local/bin/pecl: line 28: exec: /usr/local/Cellar/[email protected]/7.2.24_2/bin/php: cannot execute: No such file or directory): failed to open stream: No such file or directory in /Users/sander/.composer/vendor/weprovide/valet-plus/cli/Valet/Filesystem.php on line 112

[Neodork]

@SanderAtom Thanks for the review I'll fix the typos and rehit the CI/CD.

So if I understand correctly it works as intended?

[SanderAtom]

Yes, I don't think it's worth it to check for my specific situation.

[Neodork]

@SanderAtom Yeah this commit is also not geared towards solving the issues. But more towards keeping valet-plus intact if encountering one.

I feel like the fixing part is for valet fix