Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[TASK] xdebug.max_nesting_level #502

Merged
merged 3 commits into from
Oct 3, 2020
Merged

[TASK] xdebug.max_nesting_level #502

merged 3 commits into from
Oct 3, 2020

Conversation

lewisvoncken
Copy link
Contributor

@lewisvoncken lewisvoncken commented Jun 18, 2020


I have read the contribution guidelines and am targeting the branch <YOUR_TARGET_BRANCH>:
Because this is a Feature which is Backwards Compatible.

Changelog entry:
Short description of your work as explained by: Keep A Changelog.

Added

  • set xdebug.max_nesting_level to -1

@lewisvoncken lewisvoncken mentioned this pull request Jun 18, 2020
4 tasks
@@ -67,3 +67,4 @@ xdebug.remote_host=localhost
xdebug.remote_port=9000
xdebug.remote_autostart=1
xdebug.idekey=PHPSTORM
xdebug.max_nesting_level=2000

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

at the comment you wrote 200, but here you set it to 2000

Copy link
Member

@mischabraam mischabraam Sep 27, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't mind just setting this to -1. At least, that's what I do locally.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mischabraam that has been updated.

@Neodork
Copy link
Collaborator

Neodork commented Oct 3, 2020

/AzurePipelines run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@Neodork
Copy link
Collaborator

Neodork commented Oct 3, 2020

All tests green, this is getting merged!

@Neodork Neodork merged commit d0ee2f7 into weprovide:2.x Oct 3, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants