Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix valet fix forcefully reinstalling and relinking the default PHP version #537

Merged

Conversation

Neodork
Copy link
Collaborator

@Neodork Neodork commented Oct 1, 2020


I have read the contribution guidelines and am targeting the branch 2.x:
Because this is a Bug Fix which is Backwards Compatible.

Changelog entry:

  • Fixed valet fix forcefully trying to reinstall and relink the default PHP version. Even when not on the default version. Causing a faulty link process (overwriting).

@Neodork Neodork added 2.x Issues / features related the the 2.x branch Bug Bugs PATCH This change is patch level labels Oct 1, 2020
@Neodork Neodork force-pushed the bugfix/#536_valet_fix_forces_reinstall branch 5 times, most recently from 165a97a to 81250fc Compare October 2, 2020 16:20
@Neodork Neodork force-pushed the bugfix/#536_valet_fix_forces_reinstall branch from 81250fc to 86caf77 Compare October 2, 2020 17:03
@Neodork
Copy link
Collaborator Author

Neodork commented Oct 2, 2020

All tests green, merging.

@Neodork Neodork merged commit 3db9d71 into weprovide:2.x Oct 2, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
2.x Issues / features related the the 2.x branch Bug Bugs PATCH This change is patch level
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant