Extra HTTP headers can be passed with CreateOptions #223
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
rgba
commented
Jul 18, 2019
rgba
commented
- fixes Sending Authentication/token Info Sending Authentication/token Info #142
- fixes Add extra http header Add extra http header #198
- fixes Sending Authentication/token Info westy92#142 - fixes Add extra http header westy92#198
westy92
requested changes
Jul 18, 2019
|
Thank you so much for your contribution! I left a few comments. |
- extraHTTPHeaders are now passed as string:string mapping, this is a much cleaner solution as this does not longer require an additional step to map data into the correct format - enhanced test case to check if passing multiple headers works correctly - fixed linting and performance issues
Codecov Report
@@ Coverage Diff @@
## master #223 +/- ##
=====================================
Coverage 100% 100%
=====================================
Files 9 9
Lines 143 145 +2
Branches 19 20 +1
=====================================
+ Hits 143 145 +2
Continue to review full report at Codecov.
|
|
@westy92 Thank you very much for the detailed code review, I think the code should be in good shape now :) |
westy92
approved these changes
Jul 19, 2019
|
I just published this with v0.6.0. |
|
@westy92 Awesome! Thank you very much! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.