Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: specify owner index on coinbase smart wallet #2896

Merged
merged 6 commits into from
Nov 1, 2024

Conversation

stephancill
Copy link
Contributor

@stephancill stephancill commented Oct 20, 2024

Adds an ownerIndex to toCoinbaseSmartWallet params which allows the user specify the index of the owner to be encoded in signatures. Discussion: #2851


PR-Codex overview

This PR introduces the ownerIndex parameter to the toCoinbaseSmartAccount function, allowing users to specify which owner to use for signing messages. It includes updates to the documentation and tests to reflect this new functionality.

Detailed summary

  • Added ownerIndex parameter to toCoinbaseSmartAccount.
  • Updated documentation to include ownerIndex details.
  • Modified toCoinbaseSmartAccount implementation to utilize ownerIndex.
  • Enhanced tests to cover scenarios with multiple owners and different ownerIndex values.

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

Copy link

changeset-bot bot commented Oct 20, 2024

🦋 Changeset detected

Latest commit: 71a19d7

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
viem Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link

vercel bot commented Oct 20, 2024

@stephancill is attempting to deploy a commit to the Wevm Team on Vercel.

A member of the Team first needs to authorize it.

@jxom jxom merged commit c0367c8 into wevm:main Nov 1, 2024
2 of 5 checks passed
@github-actions github-actions bot mentioned this pull request Oct 30, 2024
@tmm tmm mentioned this pull request Dec 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants