-
-
Notifications
You must be signed in to change notification settings - Fork 961
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
finalizeWithdrawal: specify the proofSubmitter #3204
Conversation
🦋 Changeset detectedLatest commit: 13f1bee The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
@hamdiallam is attempting to deploy a commit to the Wevm Team on Vercel. A member of the Team first needs to authorize it. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- Please rename from "submittor" to "submitter".
- Needs a changeset (
pnpm changeset
) - Need to add
proofSubmitter
to docs.
OptimismPortal2 introduces
finalizeWithdrawalTransactionExternalProof
such that the calling sender does not have to match the original proof submittor.With the current structure of the viem hook, the caller must be the proof submitter in order for the finalizing tx to succesfully execute
Introduce an optional
proofSubmittor
argument to the simulating and executing hook forfinalizeWithdrawalTransaction
. If set, use the the altered function. This introduces this functionality in a backwards compatible way.