fix: metadata handling for empty URL (#4458)

wevm · Dec 12, 2024 · 987404f · 987404f
1 parent 827e470
commit 987404f
Show file tree

Hide file tree

Showing 2 changed files with 13 additions and 5 deletions.
diff --git a/.changeset/nasty-planets-play.md b/.changeset/nasty-planets-play.md
@@ -0,0 +1,5 @@
+---
+"@wagmi/connectors": patch
+---
+
+Fixed MetaMask internal metadata handling.
diff --git a/packages/connectors/src/metaMask.ts b/packages/connectors/src/metaMask.ts
@@ -262,12 +262,15 @@ export function metaMask(parameters: MetaMaskParameters = {}) {
           readonlyRPCMap,
           dappMetadata: {
             ...parameters.dappMetadata,
-            name: parameters.dappMetadata?.name ?? 'wagmi',
-            url:
-              parameters.dappMetadata?.url ??
-              (typeof window !== 'undefined'
+            // Test if name and url are set AND not empty
+            name: parameters.dappMetadata?.name
+              ? parameters.dappMetadata?.name
+              : 'wagmi',
+            url: parameters.dappMetadata?.url
+              ? parameters.dappMetadata?.url
+              : typeof window !== 'undefined'
                 ? window.location.origin
-                : 'https://wagmi.sh'),
+                : 'https://wagmi.sh',
           },
           useDeeplink: parameters.useDeeplink ?? true,
         })