Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade to coinbaseWallet v4.0.2 #3972

Merged
merged 2 commits into from
May 23, 2024
Merged

Upgrade to coinbaseWallet v4.0.2 #3972

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
d17a7d8
update coinbase wallet sdk to 4.0.2
nateReiners May 22, 2024
bdf86ed
chore: changeset
tmm May 23, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/quick-onions-shout.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
"@wagmi/connectors": patch
---

Bumped Coinbase Wallet SDK.
2 changes: 1 addition & 1 deletion packages/connectors/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -45,7 +45,7 @@
}
},
"dependencies": {
"@coinbase/wallet-sdk": "4.0.0",
"@coinbase/wallet-sdk": "4.0.2",
"@metamask/sdk": "0.20.3",
"@safe-global/safe-apps-provider": "0.18.1",
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great Coinbase is not usee friendly.

"@safe-global/safe-apps-sdk": "8.1.0",
Expand Down
10 changes: 7 additions & 3 deletions packages/connectors/src/coinbaseWallet.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,8 @@
import type { CoinbaseWalletSDK, ProviderInterface } from '@coinbase/wallet-sdk'
import type {
CoinbaseWalletSDK,
Preference,
ProviderInterface,
} from '@coinbase/wallet-sdk'
import {
ChainNotConfiguredError,
type Connector,
Expand Down Expand Up @@ -64,8 +68,8 @@ type Version4Parameters = Mutable<
* Preference for the type of wallet to display.
* @default 'all'
*/
preference?: 'all' | 'smartWalletOnly' | 'eoaOnly' | undefined
keysUrl?: string | undefined
preference?: Preference['options'] | undefined
keysUrl?: Preference['keysUrl'] | undefined
}
>

Expand Down
Loading
Loading