-
-
Notifications
You must be signed in to change notification settings - Fork 836
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Lag when switching between Stage manager tasks (macOS Ventura) #2669
Comments
Maybe it helps someone: my current workaround is to deactivate all macOS animations by activating |
MacOS's poor OpenGL support likely causes this. Adding |
Those that are experiencing this: are you on Intel or Apple Silicon? You may wish to try adding: front_end = "WebGpu" to your config to use Metal rather than OpenGL. WebGPU is currently experimental: |
Apple Silicon here. Using |
Also Apple Silicon here. I have also tried |
Can you try setting |
Yes, it's the case: with this setting, it seems smooth. |
Evidence: * #310 (comment) * #2669 (comment) * #2669 (comment) seems to suggest that window shadows hurt performance, so add a way to disable them independently from window opacity. You may use: ``` config.window_decorations = "TITLE|RESIZE|MACOS_FORCE_DISABLE_SHADOW" ``` for this. refs: #2669
Ok, I think we've re-discovered the findings from: at that time we turned off window shadows on macOS to improve performance after troubleshooting some ghostly artifacts when using transparent windows and discovering that shadows always hurt performance. Subsequently, shadows were restored for opqaue windows by: I just pushed a commit that allows you to do:
to force them to be disabled independently from the I haven't put too much thought into whether the default behavior should change for this. I'm leaning towards making it fast by default, but I'm open to hearing input from others before committing to a change. @fanzeyi: do you have strong feelings about this? |
Thanks for checking with me. Personally I feel a window looks weird on macOS if the drop shadow is not there, but I think it's largely just my preference. So yeah as long as there is a way to get it back. I don't have strong feelings about what default it should be. |
Evidence: * wez#310 (comment) * wez#2669 (comment) * wez#2669 (comment) seems to suggest that window shadows hurt performance, so add a way to disable them independently from window opacity. You may use: ``` config.window_decorations = "TITLE|RESIZE|MACOS_FORCE_DISABLE_SHADOW" ``` for this. refs: wez#2669
@wez I confirm that the lag is not here anymore with this config (version 20230320). As I use the term full screen, it's not a problem to not have the shadow. Thank you so much! |
@noefroidevaux please open a separate issue for that! |
See wez/wezterm#2669 for more details.
Bless you all, this issue was driving me nuts, because it didn't just affect the stage manager, but also Mission Control. Everything slowed down on any window animation until I added window_decorations = "TITLE|RESIZE|MACOS_FORCE_DISABLE_SHADOW" (But I also removed the Here is a visual comparison between iTerm and wezterm without the setting above, in case someone need something to relate to: 2024-01-23.12.10.57.mp4With the above setting I can see there is no shadow on the window anymore, but it's finally snappy and all. I tradeoff worth making, but it would be great if this could be fixed for people in the future. It wasn't so easy to find this issue. |
fixing wez/wezterm#2669 on macOS
Setting the window opacity also disables the shadow. So both paths are probably addressing the same underlying issue. |
This seems to be fixed somehow? I updated to the newest macOS, and the lag does not happen anymore. |
MacOS 15 or the new release of 14 (14.7 iirc)? |
macOS 15. I am not exactly sure because i cannot roll back easily to previous versions, can anybody confirm this? |
On MacOS 15 (Sequoia) the lag seems to be gone... So it was more of an Apple bug 🙂 I think we can close the ticket 🎉 |
That's pretty awesome news. Thanks for keeping us updated. |
Hey, just wanted to say Apple Intel here on Sequoia, I also had the lag issues and fixed it with MACOS_FORCE_DISABLE_SHADOW. |
What Operating System(s) are you seeing this problem on?
macOS
Which Wayland compositor or X11 Window manager(s) are you using?
-
WezTerm version
20220905-102802-7d4b8249
Did you try the latest nightly build to see if the issue is better (or worse!) than your current version?
Yes, and I updated the version box above to show the version of the nightly that I tried
Describe the bug
When I switch between State manager tasks on macOS Ventrua, the animation is fluid... but when I switch from/to WezTerm, the animation is very laggy. The lag is more visible when the window of WezTerm is bigger.
To Reproduce
Use State manager on macOS Ventura and switch between tasks (including the one which has WezTerm).
Configuration
Expected Behavior
No lag when switching from/to WezTerm using macOS Ventura Stage manager
Logs
Many
WARN wezterm_term::terminalstate > unhandled SetMode(Unspecified(34))
Anything else?
No response
The text was updated successfully, but these errors were encountered: