-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Release/v2.0.0 #34
Open
marcwieland95
wants to merge
8
commits into
master
Choose a base branch
from
release/v2.0.0
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Release/v2.0.0 #34
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marcwieland95
force-pushed
the
release/v2.0.0
branch
2 times, most recently
from
December 10, 2024 06:41
595eab2
to
e778bb3
Compare
The PER-CS2.0 ruleset of Symfony doesn't match the documentation. We choose the more readable version, which is also part of the official PER-CS2.0 ruleset (https://cs.symfony.com/doc/ruleSets/PER-CS2.0.html) #15
… standards as well
marcwieland95
force-pushed
the
release/v2.0.0
branch
from
December 11, 2024 04:05
4413f3c
to
8666429
Compare
the SymfonySet defines
https://github.com/PHP-CS-Fixer/PHP-CS-Fixer/blob/master/src/RuleSet/Sets/SymfonySet.php#L206 our ECS config enforces it |
Same issuse
https://github.com/PHP-CS-Fixer/PHP-CS-Fixer/blob/master/src/RuleSet/Sets/SymfonySet.php#L219 our ECS enforces for 'arguments' |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Here we go. I went through all the issues we had. Solved them and cleaned up more issues.
Since we're adding PER Coding Style 2.0 (https://www.php-fig.org/per/coding-style/), it's a major release.
I ran it on a local project, and I could auto-fix all changes. The following rules had to be changed:
The updates @rugbymauri is working on with CS Fixer aren't ready yet, and I created a milestone for those adjustments. Once this is ready, we see if there's another major needed or if it's backwards compatible. For now, I want to release those adjustments to have a clean base again.