-
Notifications
You must be signed in to change notification settings - Fork 300
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Event.prototype.deepPath as an attribute breaks TinyMCE 4.3.10 #242
Comments
What would a good alternative name be? |
I like |
Are there other parts of the API that should make the deep -> composed substitution for consistency? |
As far as I know this is the only API that uses "deep" thus far. There's several open issues about adding more, but nothing remotely conclusive. The other APIs that can go "downward" are |
Perhaps |
That does not seem entirely unreasonable (though I'd spell it |
How about |
I think those are more confusing than |
whatwg/html#1160 suggests either |
Apparently, this problem was caused by TinyMCE 4.3.10, which is included in WordPress 4.5 on the contrary to my earlier statement. (Thanks @apple-web-evangelist for figuring this out!) So we probably need to do this rename since there will be a lot of websites that have this version of WordPress and/or TinyMCE and never update to a new version :( |
So @smaug---- does not like Different direction: |
|
@rniwa I think ideally we have something that can also be used for |
How about Or Yet another alternative: One more: |
I suspect @smaug---- would not like those for the same reason he did not like piercing. Is |
I don't like it because |
I talked with @smaug---- on #whatwg and he seems to like WDYT? |
"like". I can live with dispatchPath is perhaps closer ;) though, dispatchPath doesn't play well with findRootNode, if that is one goal. |
composedPath and findRootNode({composedTree: true}) ? |
I don't think |
hmm, sounds like we have different meaning for composed tree. You think it as a synonym to flattened tree, I think. For me composed tree is the tree of node trees, including shadow roots and everything. And if we don't use composed for anything else, it is a good thing. less likely to cause confusion. |
That's a good point. Okay, with that, we can do |
And |
composed is no longer a reserved word in the Shadow DOM spec. I stopped using this term in normative sections about a few month ago. Now, we can use it freely in any meaning, if we want to re-use it. I am fine with |
Let's go with |
https://bugs.webkit.org/show_bug.cgi?id=157475 Reviewed by Antti Koivisto. Source/WebCore: Renamed Event.prototype.deepPath() to composedPath() per discussions on whatwg/dom#242 as the old name was not Web compatible. Test: fast/shadow-dom/Extensions-to-Event-Interface.html * dom/Event.cpp: (WebCore::Event::composedPath): Renamed from deepPath. * dom/Event.h: * dom/Event.idl: LayoutTests: Updated the tests. * fast/shadow-dom/Extensions-to-Event-Interface-expected.txt: * fast/shadow-dom/Extensions-to-Event-Interface.html: * fast/shadow-dom/resources/event-path-test-helpers.js: (dispatchEventWithLog): git-svn-id: http://svn.webkit.org/repository/webkit/trunk@200580 268f45cc-cd09-0410-ab3c-d52691b4dbfc
Fixes #242. Also reverts WICG/webcomponents#432 as it appears to no longer be needed. If we ever have an event path that starts with a non-node and ends with a node we'll have to add that complexity back. (The reason it is named composedPath() is because deepPath() and various other names were no longer viable after Chrome's initial experiment. See the various issues.)
Fixes #242. Also reverts WICG/webcomponents#432 as it appears to no longer be needed. If we ever have an event path that starts with a non-node and ends with a node we'll have to add that complexity back. (The reason it is named composedPath() is because deepPath() and various other names were no longer viable after Chrome's initial experiment. See the various issues.)
Event.deepPath() was renamed to composedPath(). See whatwg/dom#242
Event.deepPath() was renamed to composedPath(). See whatwg/dom#242
Event.deepPath() was renamed to composedPath(). See whatwg/dom#242
Event.deepPath() was renamed to composedPath(). See whatwg/dom#242
https://bugs.webkit.org/show_bug.cgi?id=157475 Reviewed by Antti Koivisto. Source/WebCore: Renamed Event.prototype.deepPath() to composedPath() per discussions on whatwg/dom#242 as the old name was not Web compatible. Test: fast/shadow-dom/Extensions-to-Event-Interface.html * dom/Event.cpp: (WebCore::Event::composedPath): Renamed from deepPath. * dom/Event.h: * dom/Event.idl: LayoutTests: Updated the tests. * fast/shadow-dom/Extensions-to-Event-Interface-expected.txt: * fast/shadow-dom/Extensions-to-Event-Interface.html: * fast/shadow-dom/resources/event-path-test-helpers.js: (dispatchEventWithLog): git-svn-id: http://svn.webkit.org/repository/webkit/trunk@200580 268f45cc-cd09-0410-ab3c-d52691b4dbfc
https://bugs.webkit.org/show_bug.cgi?id=157475 Reviewed by Antti Koivisto. Source/WebCore: Renamed Event.prototype.deepPath() to composedPath() per discussions on whatwg/dom#242 as the old name was not Web compatible. Test: fast/shadow-dom/Extensions-to-Event-Interface.html * dom/Event.cpp: (WebCore::Event::composedPath): Renamed from deepPath. * dom/Event.h: * dom/Event.idl: LayoutTests: Updated the tests. * fast/shadow-dom/Extensions-to-Event-Interface-expected.txt: * fast/shadow-dom/Extensions-to-Event-Interface.html: * fast/shadow-dom/resources/event-path-test-helpers.js: (dispatchEventWithLog): git-svn-id: http://svn.webkit.org/repository/webkit/trunk@200580 268f45cc-cd09-0410-ab3c-d52691b4dbfc
https://bugs.webkit.org/show_bug.cgi?id=157475 Reviewed by Antti Koivisto. Source/WebCore: Renamed Event.prototype.deepPath() to composedPath() per discussions on whatwg/dom#242 as the old name was not Web compatible. Test: fast/shadow-dom/Extensions-to-Event-Interface.html * dom/Event.cpp: (WebCore::Event::composedPath): Renamed from deepPath. * dom/Event.h: * dom/Event.idl: LayoutTests: Updated the tests. * fast/shadow-dom/Extensions-to-Event-Interface-expected.txt: * fast/shadow-dom/Extensions-to-Event-Interface.html: * fast/shadow-dom/resources/event-path-test-helpers.js: (dispatchEventWithLog): git-svn-id: http://svn.webkit.org/repository/webkit/trunk@200580 268f45cc-cd09-0410-ab3c-d52691b4dbfc
https://bugs.webkit.org/show_bug.cgi?id=157475 Reviewed by Antti Koivisto. Source/WebCore: Renamed Event.prototype.deepPath() to composedPath() per discussions on whatwg/dom#242 as the old name was not Web compatible. Test: fast/shadow-dom/Extensions-to-Event-Interface.html * dom/Event.cpp: (WebCore::Event::composedPath): Renamed from deepPath. * dom/Event.h: * dom/Event.idl: LayoutTests: Updated the tests. * fast/shadow-dom/Extensions-to-Event-Interface-expected.txt: * fast/shadow-dom/Extensions-to-Event-Interface.html: * fast/shadow-dom/resources/event-path-test-helpers.js: (dispatchEventWithLog): Canonical link: https://commits.webkit.org/175611@main git-svn-id: https://svn.webkit.org/repository/webkit/trunk@200580 268f45cc-cd09-0410-ab3c-d52691b4dbfc
This is probably an evangelism but wordpress.com breaks due to its use of deepPath as an attribute. Specifically, they have a code that retrieves
event.deepPath[0]
.The text was updated successfully, but these errors were encountered: