Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

event.composedPath() should not return every items in path if event.currentTarget is window #326

Closed
hayatoito opened this issue Sep 13, 2016 · 3 comments
Closed

event.composedPath() should not return every items in path if event.currentTarget is window #326

hayatoito opened this issue Sep 13, 2016 · 3 comments

Comments

@hayatoito
Copy link
Member

According to the current composedPath() definition, window.composedPath() would
return every items, even if the item's root is a closed shadow root, because
window is not a node.
hayatoito added a commit that referenced this issue Sep 13, 2016
@hayatoito
Shadow: Make window.composedPath() use closed-shadow-hidden
7f1c549 
Fixes #326.
@hayatoito hayatoito mentioned this issue Sep 13, 2016
Merged
@annevk
Copy link
Member

annevk commented Sep 13, 2016

Why would window have a composedPath() method?

@hayatoito
Copy link
Member Author

Ah. That's my mistake.
I meant that event.comopsedPath() is called from an event listener registered on window.

Let me update the PR and this issue.

@hayatoito hayatoito changed the title window.composedPath() should not return every items in path event.composedPath() should not return every items in path if event.currentTarget is window Sep 13, 2016
hayatoito added a commit that referenced this issue Sep 13, 2016
@hayatoito
Shadow: Make Event.composedPath() use closed-shadow-hidden when curre…
1f2c67d 
…ntTarget is window

Fixes #326.
@hayatoito
Copy link
Member Author

I have updated the PR. Could you have a chance to take a look?

hayatoito added a commit that referenced this issue Sep 13, 2016
@hayatoito
Shadow: Make Event.composedPath() use closed-shadow-hidden when curre…
3832daa 
…ntTarget is window

Fixes #326.
hayatoito added a commit that referenced this issue Sep 13, 2016
@hayatoito
Shadow: Make Event.composedPath() use closed-shadow-hidden when curre…
4e5a24d 
…ntTarget is window

Fixes #326.
annevk pushed a commit that referenced this issue Sep 14, 2016
@hayatoito @annevk
Shadow: adjust composedPath() when currentTarget is a Window object
2153769 
Fixes #326.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@hayatoito @annevk