Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Editorial: remove parent argument to remove #801

Closed
annevk opened this issue Dec 6, 2019 · 0 comments · Fixed by #805
Closed

Editorial: remove parent argument to remove #801

annevk opened this issue Dec 6, 2019 · 0 comments · Fixed by #805

Comments

@annevk
Copy link
Member

annevk commented Dec 6, 2019

A number of callers don't give it and callers do check for parent being non-null before calling. It seems we should assert it's non-null and then use that. I.e., turn the internal concept into being closer to child.remove() rather than parent.removeChild(child).

Bonus: clean up attribute removal in a similar fashion.
annevk added a commit that referenced this issue Dec 6, 2019
@annevk
Editorial: remove parent argument to remove
79a26c8 
Helps with #801. Closes #802.
@annevk annevk mentioned this issue Dec 6, 2019
Merged
annevk added a commit that referenced this issue Dec 6, 2019
@annevk
Editorial: remove parent argument to remove
37d8475 
Helps with #801.
annevk added a commit that referenced this issue Dec 6, 2019
@annevk
Editorial: embrace that attributes are objects
e75f107 
Closes #801.
@annevk annevk mentioned this issue Dec 6, 2019
Merged
annevk added a commit that referenced this issue Dec 11, 2019
@annevk
Editorial: embrace that attributes are objects
0038d09 
Closes #801. (Also closes #802 and closes #807.)
koto pushed a commit to koto/dom that referenced this issue Dec 12, 2019
@annevk @koto
Editorial: embrace that attributes are objects
a2ab430 
Closes whatwg#801.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Editorial: embrace that attributes are objects whatwg/dom
1 participant
@annevk