Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Element.matches(selectors) seeming typo / missing step #921

Closed
danburzo opened this issue Nov 10, 2020 · 2 comments · Fixed by #923
Closed

Element.matches(selectors) seeming typo / missing step #921

danburzo opened this issue Nov 10, 2020 · 2 comments · Fixed by #923

Comments

@danburzo
Copy link

In the definition of Element.matches(selectors), element from step 3 has not previously defined. Probably should be replaced with this?
@domenic domenic transferred this issue from whatwg/html Nov 10, 2020
@danburzo
Copy link
Author

Oops, thanks @domenic, I need to stop logging issues after a day of staring at specs. Makes sense now why my "search" in GH issues on "matches" didn't yield any of the expected results :-)

annevk added a commit that referenced this issue Nov 11, 2020
@annevk
Correct step in matches()
69871c8 
It needs to pass this rather than an undefined variable. Also clean up the algorithm a bit.

Fixes #921.
@annevk annevk mentioned this issue Nov 11, 2020
Merged
@annevk
Copy link
Member

annevk commented Nov 11, 2020

Thanks @danburzo, PR up for review at #923.

annevk added a commit that referenced this issue Jan 19, 2021
@annevk
Correct step in matches()
fd6673c 
It needs to pass this rather than an undefined variable. Also clean up the algorithm a bit.

Fixes #921.
annevk added a commit that referenced this issue Jan 19, 2021
@annevk
Correct step in matches()
816bbfb 
It needs to pass this rather than an undefined variable. Also clean up the algorithm a bit.

Fixes #921.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Correct step in matches() whatwg/dom
2 participants
@danburzo @annevk