Don't set custom element state redundantly #253
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This LGTM. Am I right in understanding that I can review the .bs files and ignore the HTML files in these PRs, because presumably the HTML file is generated by a tool? |
|
Yep, exactly |
|
@annevk I rebased this and the requisite HTML PR is merged so it should be good to go. |
As of whatwg/html#1309, this is no longer necessary, as it is taken care of in the Construct(C) step.
|
I should not have attempted to fix the date. That took so much longer than anticipated... |
domenic
added
the
topic: custom elements
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As of whatwg/html#1309, this is no longer necessary, as it is taken care of in the Construct(C) step.
Ideally don't merge this until that PR is merged.