Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Editorial: Missing definitive article #834

Merged
merged 3 commits into from
Feb 12, 2020
Merged

Editorial: Missing definitive article #834

merged 3 commits into from
Feb 12, 2020

Conversation

@annevk
Copy link
Member

annevk commented Feb 12, 2020

Thanks, would you like to add yourself to the Acknowledgments section?

@snuggs
Copy link
Member Author

snuggs commented Feb 12, 2020

Thanks, would you like to add yourself to the Acknowledgments section?

@annevk been there done that (thanks to you) 😄
I have been using my first name since my Mother passed over the holiday. Ra'Shaun is my middle name. Updated in 180cac7.

That said...I was going to change the previous person's acknowledgement as it looks like something funky went on at the tail end. However didn't feel I had right to touch someone else's acknowledgement. I crossed my fingers and attempted to blame dom.bs to see if I did that when I was added a while back but takes so long github says "taking too long to load". I've always gotten this but never bought it up. I digress.

Should we just leave it alone?

@annevk
Copy link
Member

annevk commented Feb 12, 2020

Yeah, leave that one alone, but you want to resort yours.

@snuggs
Copy link
Member Author

snuggs commented Feb 12, 2020

@annevk ok what left needs to be done? Says needs to be merged by someone else.
I know you have better things to do. :-)

Thank you so much!

@annevk
Copy link
Member

annevk commented Feb 12, 2020

Well, the Acknowledgments section is sorted on the (overall) name and you changed your name, but not how it's sorted.

@snuggs
Copy link
Member Author

snuggs commented Feb 12, 2020

@annevk AHH RE-sort...Was thinking 🌴resort🌴.
I need a vacation. Should be good now. Thanks!

@annevk annevk merged commit b4e91f5 into whatwg:master Feb 12, 2020
@snuggs snuggs deleted the patch-2 branch February 12, 2020 17:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants