Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Imperative Slot API #860

Closed
wants to merge 17 commits into from
Closed

Add Imperative Slot API #860

Changes from 5 commits
Commits
Show all changes
17 commits
Select commit Hold shift + click to select a range
51f3b93
Add Imperative Slot API
Apr 22, 2020
bc401e1
Update slot assignment default wording
Apr 24, 2020
c62252e
Updates Imperative Slot API spec.
Apr 29, 2020
4998818
Updates to include manuallyAssignedNodes.
May 14, 2020
d09a978
Update Imperative Slot API dom spec
Jun 5, 2020
d07a843
Update dom.bs
yuzhe-han Jun 17, 2020
eed81d3
Update dom.bs
yuzhe-han Jun 17, 2020
e8fdb61
Update Imperative Slot API Spec.
Jun 17, 2020
3ab244d
Update Imperative Slot API DOM spec
Jul 18, 2020
ae51d53
Update Slot Imperative API DOM spec.
Jul 22, 2020
adf8f64
Update Slot Imperative API DOM Spec.
Jul 22, 2020
26b8b99
Update Imperative Slot API DOM spec
Oct 17, 2020
b131976
Merge remote-tracking branch 'upstream/master'
Oct 17, 2020
901506d
Update Imperative Slot API DOM spec
Oct 17, 2020
31ab480
Update Imperative Slot API DOM spec
Nov 12, 2020
55101bd
Merge remote-tracking branch 'upstream/master'
Dec 31, 2020
49ce986
Update imperative slot assignment DOM spec
Dec 31, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 18 additions & 1 deletion dom.bs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2195,6 +2195,10 @@ steps:</p>
<li><p>If the <i>open flag</i> is set and <var>shadow</var>'s <a for=ShadowRoot>mode</a> is
<em>not</em> "<code>open</code>", then return null.</p></li>

<li><p>If the <var>shadow</var>'s <a for=ShadowRoot>slot assignment</a> is set to "<code>manual</code>",
yuzhe-han marked this conversation as resolved.
Show resolved Hide resolved
return the slot in <var>shadow</var>'s <a for=tree>descendants</a> whose <a>manuallyAssignedNodes</a>
yuzhe-han marked this conversation as resolved.
Show resolved Hide resolved
yuzhe-han marked this conversation as resolved.
Show resolved Hide resolved
includes <var>slottable</var>, if any, and null otherwise.</p></li>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you want <a for=set>contains</a> instead of includes here I think. It's a set right?

And I guess we're not bothering with tree order and such since there can only be one such slot.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks. Yes, contains is correct. I see how the verbiage is being used.
Right, there's can only be one slot because the corresponding HTML spec for HTMLSlotElement::assign() ensures that.


<li><p>Return the first <a>slot</a> in <a>tree order</a> in <var>shadow</var>'s
<a for=tree>descendants</a> whose <a for=slot>name</a> is <var>slottable</var>'s
<a for=slottable>name</a>, if any, and null otherwise.</p></li>
Expand Down Expand Up @@ -5711,11 +5715,13 @@ invoked, must return a new {{DocumentFragment}} <a>node</a> whose <a for=Node>no
[Exposed=Window]
interface ShadowRoot : DocumentFragment {
readonly attribute ShadowRootMode mode;
readonly attribute SlotAssignmentMode slotAssignment;
readonly attribute Element host;
attribute EventHandler onslotchange;
};

enum ShadowRootMode { "open", "closed" };
enum SlotAssignmentMode { "manual", "auto" };
annevk marked this conversation as resolved.
Show resolved Hide resolved
</pre>

<p>{{ShadowRoot}} <a for=/>nodes</a> are simply known as
Expand All @@ -5731,6 +5737,9 @@ It is initially set to false.</p>
<!-- If we ever change this, e.g., add a ShadowRoot object constructor, that would have serious
consequences for innerHTML. -->

<p><a for=/>Shadow roots</a> have an associated <dfn for=ShadowRoot>slot assignment</dfn>
("<code>manual</code>" or "<code>auto</code>").</p>

<p>A <a for=/>shadow root</a>'s <a>get the parent</a> algorithm, given an <var>event</var>, returns
null if <var>event</var>'s <a>composed flag</a> is unset and <a for=/>shadow root</a> is the
<a for=tree>root</a> of <var>event</var>'s <a for=Event>path</a>'s first struct's
Expand All @@ -5748,6 +5757,9 @@ null if <var>event</var>'s <a>composed flag</a> is unset and <a for=/>shadow roo
<dfn for=ShadowRoot export><code>onslotchange</code></dfn> <a>event handler</a>, whose
<a>event handler event type</a> is {{HTMLSlotElement/slotchange}}.

<p>The <dfn attribute for=ShadowRoot><code>slotAssignment</code></dfn> attribute's getter must
return <a>this</a>'s <a for=ShadowRoot>slot assignment</a>.</p>

<hr>

<p>In <dfn export id=concept-shadow-including-tree-order>shadow-including tree order</dfn> is
Expand Down Expand Up @@ -5871,6 +5883,7 @@ interface Element : Node {
dictionary ShadowRootInit {
required ShadowRootMode mode;
boolean delegatesFocus = false;
SlotAssignmentMode slotAssignment = "auto";
};
</pre>

Expand Down Expand Up @@ -6744,6 +6757,9 @@ invoked, must run these steps:
<li><p>Set <var>shadow</var>'s <a for=ShadowRoot>delegates focus</a> to <var>init</var>'s
{{ShadowRootInit/delegatesFocus}}.

<li><p>Set <var>shadow</var>'s <a for=ShadowRoot>slot assignment</a> to <var>init</var>'s
{{ShadowRootInit/slotAssignment}}.

<li><p>Set <a>this</a>'s <a for=Element>shadow root</a> to <var>shadow</var>.

<li><p>Return <var>shadow</var>.
Expand Down Expand Up @@ -10187,7 +10203,8 @@ Xidorn Quan,
Yehuda Katz,
Yoav Weiss,
Yoichi Osato,
Yoshinori Sano, and
Yoshinori Sano,
Yu Han, <!-- yuzhe-han on GitHub --> and
Zack Weinberg
for being awesome!

Expand Down