Add ShadowRoot.prototype.delegatesFocus attribute #974
+7
−3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
foolip
added a commit
to web-platform-tests/wpt
that referenced
this pull request
Apr 20, 2021
foolip
commented
Apr 20, 2021
| <p>The <dfn attribute for=ShadowRoot><code>delegatesFocus</code></dfn> getter steps are to return | ||
| <a>this</a>'s <a for=ShadowRoot>delegates focus</a>.</p> | ||
|
|
||
| <p>The <dfn attribute for=ShadowRoot><code>slotAssignment</code></dfn> getter steps are to return |
There was a problem hiding this comment.
I changed the order to match the IDL here.
There was a problem hiding this comment.
Thanks! (Here I thought I could keep blame clean by using the modern wording when landing slot assignment. There's always further nits. 😊)
annevk
approved these changes
Apr 20, 2021
foolip
added a commit
to web-platform-tests/wpt
that referenced
this pull request
Apr 21, 2021
moz-v2v-gh
pushed a commit
to mozilla/gecko-dev
that referenced
this pull request
Apr 25, 2021
…te, a=testonly Automatic update from web-platform-tests Test ShadowRoot's delegatesFocus attribute (#28593) Follows whatwg/dom#974. -- wpt-commits: 9ee6580ff84c00e6a6929b8edfe60ae99fafd1ab wpt-pr: 28593
sideshowbarker
added a commit
to w3c/browser-compat-data
that referenced
this pull request
Apr 27, 2021
whatwg/dom#974 added ShadowRoot.prototype.delegatesFocus to the DOM spec (see whatwg/dom@f346858). And per whatwg/dom#931 (comment) (https://trac.webkit.org/r276585) it’s been implemented in WebKit. So given that now it’s part of the DOM standard, and implemented in multiple browsers, this changes resets the BCD status flags for it.
sideshowbarker
added a commit
to w3c/browser-compat-data
that referenced
this pull request
Apr 27, 2021
whatwg/dom#974 added ShadowRoot.prototype.delegatesFocus to the DOM spec (see whatwg/dom@f346858). And per whatwg/dom#931 (comment) (https://trac.webkit.org/r276585) it’s been implemented in WebKit. So given that it’s now part of the DOM standard, and implemented in multiple browsers, this changes resets the BCD status flags for it.
sideshowbarker
added a commit
to w3c/browser-compat-data
that referenced
this pull request
Apr 27, 2021
whatwg/dom#974 added ShadowRoot.prototype.delegatesFocus to the DOM spec (see whatwg/dom@f346858). And per whatwg/dom#931 (comment) (https://trac.webkit.org/r276585) it’s been implemented in WebKit. So given that it’s now part of the DOM standard, and implemented in multiple browsers, this change resets the BCD status flags for it.
sideshowbarker
added a commit
to mdn/content
that referenced
this pull request
Apr 27, 2021
whatwg/dom#974 added ShadowRoot.prototype.delegatesFocus to the DOM spec (see whatwg/dom@f346858). And per whatwg/dom#931 (comment) (https://trac.webkit.org/r276585) it’s been implemented in WebKit. So given that it’s now part of the DOM standard, and implemented in multiple browsers, this change drops the Deprecated_Header macro from the source — as well as fixing the spec URL.
sideshowbarker
added a commit
to mdn/content
that referenced
this pull request
Apr 27, 2021
whatwg/dom#974 added ShadowRoot.prototype.delegatesFocus to the DOM spec (see whatwg/dom@f346858). And per whatwg/dom#931 (comment) (https://trac.webkit.org/r276585) it’s been implemented in WebKit. So given that it’s now part of the DOM standard, and implemented in multiple browsers, this change drops the Deprecated_Header macro from the source — as well as fixing the spec URL. Related BCD change: mdn/browser-compat-data#10102
sideshowbarker
added a commit
to w3c/browser-compat-data
that referenced
this pull request
Apr 27, 2021
whatwg/dom#974 added ShadowRoot.prototype.delegatesFocus to the DOM spec (see whatwg/dom@f346858). And per whatwg/dom#931 (comment) (https://trac.webkit.org/r276585) it’s been implemented in WebKit. So given that it’s now part of the DOM standard, and implemented in multiple browsers, this change resets the BCD status flags for it. Related MDN change: mdn/content#4508
foolip
pushed a commit
to mdn/browser-compat-data
that referenced
this pull request
Apr 27, 2021
whatwg/dom#974 added ShadowRoot.prototype.delegatesFocus to the DOM spec (see whatwg/dom@f346858). And per whatwg/dom#931 (comment) (https://trac.webkit.org/r276585) it’s been implemented in WebKit. So given that it’s now part of the DOM standard, and implemented in multiple browsers, this change resets the BCD status flags for it. Related MDN change: mdn/content#4508
Elchi3
pushed a commit
to mdn/content
that referenced
this pull request
Apr 27, 2021
whatwg/dom#974 added ShadowRoot.prototype.delegatesFocus to the DOM spec (see whatwg/dom@f346858). And per whatwg/dom#931 (comment) (https://trac.webkit.org/r276585) it’s been implemented in WebKit. So given that it’s now part of the DOM standard, and implemented in multiple browsers, this change drops the Deprecated_Header macro from the source — as well as fixing the spec URL. Related BCD change: mdn/browser-compat-data#10102
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #931.
(See WHATWG Working Mode: Changes for more details.)
Preview | Diff