Skip to content

Commit

Permalink
Remove trailer support
Browse files Browse the repository at this point in the history 
As noted in #772 (comment) the current way it is exposed subsets what HTTP supports and therefore does not feel like a good starting point. Both for the internal and public API.

Additionally, the public-facing API has not seen interest from implementers, at least for the past year and a half.

Tests: web-platform-tests/wpt#20720.

Closes #772. Follow-ups: #980 and #981.
  • Loading branch information
@annevk
annevk authored Dec 12, 2019
1 parent 20ec6d0 commit b93383c
Showing 1 changed file with 8 additions and 81 deletions.
89 changes: 8 additions & 81 deletions fetch.bs
View file
Original file line number Diff line number Diff line change
Expand Up @@ -1774,14 +1774,6 @@ message as HTTP/2 does not support them.
<dfn export for=response id=concept-response-body>body</dfn> (null or a
<a for=/>body</a>). Unless stated otherwise it is null.

<p>A <a for=/>response</a> has an associated
<dfn export for=response id=concept-response-trailer>trailer</dfn> (a
<a for=/>header list</a>). Unless stated otherwise it is empty.

<p>A <a for=/>response</a> has an associated
<dfn export for=response id=concept-response-trailer-failed>trailer failed flag</dfn>, which is
initially unset.

<p>A <a for=/>response</a> has an associated
<dfn export for=response id=concept-response-cache-state>cache state</dfn> (the empty string or
"<code>local</code>"). Unlesss stated otherwise, it is the empty string.
Expand Down Expand Up @@ -1852,9 +1844,8 @@ known as an <dfn export id=concept-aborted-network-error>aborted network error</
<a for=/>response</a> whose
<a for=response>status</a> is always <code>0</code>,
<a for=response>status message</a> is always the empty byte sequence,
<a for=response>header list</a> is always empty,
<a for=response>body</a> is always null, and
<a for=response>trailer</a> is always empty.
<a for=response>header list</a> is always empty, and
<a for=response>body</a> is always null.

<hr>

Expand Down Expand Up @@ -1883,36 +1874,33 @@ which is only "accessible" to internal specification algorithms and is never a

<p>A <dfn export id=concept-filtered-response-cors>CORS filtered response</dfn> is a
<a>filtered response</a> whose
<a for=response>type</a> is "<code>cors</code>",
<a for=response>type</a> is "<code>cors</code>" and
<a for=response>header list</a> excludes any
<a for=/>headers</a> in
<a for=internal>internal response</a>'s
<a for=response>header list</a> whose
<a for=header>name</a> is <em>not</em> a
<a>CORS-safelisted response-header name</a>, given
<a for=internal>internal response</a>'s
<a for=response>CORS-exposed header-name list</a>, and
<a for=response>trailer</a> is empty.
<a for=response>CORS-exposed header-name list</a>.

<p>An <dfn export id=concept-filtered-response-opaque>opaque filtered response</dfn> is a
<a>filtered response</a> whose
<a for=response>type</a> is "<code>opaque</code>",
<a for=response>URL list</a> is the empty list,
<a for=response>status</a> is <code>0</code>,
<a for=response>status message</a> is the empty byte sequence,
<a for=response>header list</a> is empty,
<a for=response>body</a> is null, and
<a for=response>trailer</a> is empty.
<a for=response>header list</a> is empty, and
<a for=response>body</a> is null.

<p>An
<dfn export id=concept-filtered-response-opaque-redirect>opaque-redirect filtered response</dfn>
is a <a>filtered response</a> whose
<a for=response>type</a> is "<code>opaqueredirect</code>",
<a for=response>status</a> is <code>0</code>,
<a for=response>status message</a> is the empty byte sequence,
<a for=response>header list</a> is empty,
<a for=response>body</a> is null, and
<a for=response>trailer</a> is empty.
<a for=response>header list</a> is empty, and
<a for=response>body</a> is null.

<div class="note no-backref">
<p>Exposing the <a for=response>URL list</a> for
Expand Down Expand Up @@ -3659,14 +3647,6 @@ optionally with a <i>recursive flag</i>, run these steps:
<li><p><a>Queue a fetch task</a> on <var>request</var> to
<a>process response end-of-body</a> for <var>response</var>.

<li><p>Wait for either <var>internalResponse</var>'s <a for=response>trailer</a>,
if any, or for the ongoing fetch to <a for=fetch lt=terminated>terminate</a>. <span class=note>See
<a href=https://tools.ietf.org/html/rfc7230#section-4.1.2>section 4.1.2</a> of
[[!HTTP]].</span>

<li><p>If the ongoing fetch is <a for=fetch>terminated</a>, then set <var>internalResponse</var>'s
<a for=response>trailer failed flag</a>.

<li><p>Set <var>request</var>'s <a>done flag</a>.

<li><p><a>Queue a fetch task</a> on <var>request</var> to <a>process response done</a>
Expand Down Expand Up @@ -6414,7 +6394,6 @@ interface Response {
readonly attribute boolean ok;
readonly attribute ByteString statusText;
[SameObject] readonly attribute Headers headers;
readonly attribute Promise&lt;Headers> trailer;

[NewObject] Response clone();
};
Expand All @@ -6436,10 +6415,6 @@ enum ResponseType { "basic", "cors", "default", "error", "opaque", "opaqueredire
<p>A {{Response}} object also has an associated <dfn for=Response export>headers</dfn> (null or a
{{Headers}} object), initially null.

<p>A {{Response}} object also has an associated
<dfn id=concept-response-trailer-promise for=Response>trailer promise</dfn> (a promise). <span class=note>Used
for the {{Response/trailer}} attribute.</span>

<p>A {{Response}} object's <a for=Body>body</a> is its
<a for=Response>response</a>'s <a for=response>body</a>.

Expand Down Expand Up @@ -6502,10 +6477,6 @@ constructor, when invoked, must run these steps:
<a>current settings object</a>'s
<a for="environment settings object">HTTPS state</a>.

<li><p>Resolve <var>r</var>'s <a for=Response>trailer promise</a>
with a new {{Headers}} object whose <a for=Headers>guard</a> is
"<code>immutable</code>".

<li><p>Return <var>r</var>.
</ol>

Expand Down Expand Up @@ -6584,9 +6555,6 @@ must return the <a>context object</a>'s <a for=Response>response</a>'s
<p>The <dfn attribute for=Response><code>headers</code></dfn> attribute's getter, when invoked, must
return the <a>context object</a>'s <a for=Response>headers</a>.

<p>The <dfn attribute for=Response><code>trailer</code></dfn> attribute's getter, when invoked, must
return the <a>context object</a>'s <a for=Response>trailer promise</a>.

<hr>

<p>The <dfn method for=Response><code>clone()</code></dfn> method, when invoked, must
Expand All @@ -6609,11 +6577,6 @@ run these steps:
<a for=Headers>header list</a>, and <a for=Headers>guard</a> is the <a>context object</a>'s
<a for=Response>headers</a>'s <a for=Headers>guard</a>.

<li><p>Upon fulfillment of the <a>context object</a>'s <a for=Response>trailer promise</a>, resolve
<var>clonedResponseObject</var>'s <a for=Response>trailer promise</a> with a new {{Headers}} object
whose <a for=Headers>guard</a> is "<code>immutable</code>", and whose
<a for="Headers">header list</a> is <var>clonedResponse</var>'s <a for=response>trailer</a>.

<li><p>Return <var>clonedResponseObject</var>.

<li><p>Return <var>clonedResponse</var>.
Expand Down Expand Up @@ -6700,36 +6663,6 @@ method, must run these steps:
<li><p>Resolve <var>p</var> with <var>responseObject</var>.
</ol>

<p>To <a>process response done</a> for <var>response</var>, run these substeps:

<ol>
<li><p>If <var>locallyAborted</var> is true, terminate these substeps.

<li><p>Let <var>trailerObject</var> be a new {{Headers}} object whose
<a for=Headers>guard</a> is "<code>immutable</code>".

<li>
<p>If <var>response</var>'s <a for=response>trailer failed flag</a> is set, then:

<ol>
<li><p>If <var>response</var>'s <a for=response>aborted flag</a> is set, reject
<var>responseObject</var>'s <a for=Response>trailer promise</a> with an
"<code><a exception>AbortError</a></code>" {{DOMException}}.

<li><p>Otherwise, reject <var>responseObject</var>'s <a for=Response>trailer promise</a> with
a {{TypeError}}.

<li><p>Terminate these substeps.
</ol>

<li><p>Associate <var>trailerObject</var> with <var>response</var>'s
<a for=response>trailer</a>.

<li><p>Resolve <var>responseObject</var>'s
<a for=Response>trailer promise</a> with
<var>trailerObject</var>.
</ol>

<li><p>Return <var>p</var>.
</ol>

Expand All @@ -6750,12 +6683,6 @@ method, must run these steps:

<li><p>If <var>responseObject</var> is null, then return.

<li>
<p>Reject <var>responseObject</var>'s <a for=Response>trailer promise</a> with <var>error</var>.

<p class=note>This is a no-op if <var>responseObject</var>'s <a for=Response>trailer promise</a>
has already fulfilled.

<li><p>Let <var>response</var> be <var>responseObject</var>'s <a for=Response>response</a>.

<li><p>If <var>response</var>'s <a for=response>body</a> is not null and is
Expand Down

0 comments on commit b93383c

Please sign in to comment.