Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Expand on processResponseEndOfBody values #1360

Merged
merged 2 commits into from
Nov 29, 2021
Merged

Expand on processResponseEndOfBody values #1360

merged 2 commits into from
Nov 29, 2021

Conversation

domenic
Copy link
Member

@domenic domenic commented Nov 24, 2021 •
edited by pr-preview bot
Loading

This helped me understand a bit better what is going on in whatwg/html#7260 (comment)

Preview | Diff

annevk
annevk approved these changes Nov 25, 2021
View reviewed changes
Copy link
Member

@annevk annevk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

The lack of dots at the end of these sentences is bothering me a bit. Would it be okay to add dots or is there something I should read up on?

@domenic
Copy link
Member Author

domenic commented Nov 29, 2021

Oh, for sure, these are full sentences and deserve a dot. I think it's just that often I write <dd>s which are not full sentences and in those cases I tend to omit the dot.

@domenic domenic merged commit 3bd2cae into main Nov 29, 2021
@domenic domenic deleted the eob-values branch November 29, 2021 16:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@annevk annevk annevk approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@domenic @annevk