-
Notifications
You must be signed in to change notification settings - Fork 2.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Web reality: Load/error events for <link> not firing on rel="icon" #6122
Labels
Comments
Great find. Upon reflection, I think making the default steps a no-op is probably best. Most links will need custom handling, and so the default steps don't buy us much. /cc @domfarolino |
andreubotella
pushed a commit
to andreubotella/html
that referenced
this issue
Nov 17, 2020
This removes the requirement for <link rel="icon"> to fire load and error events, which no implementation followed. Closes whatwg#6122.
This was referenced Nov 17, 2020
domenic
pushed a commit
to web-platform-tests/wpt
that referenced
this issue
Nov 18, 2020
domenic
pushed a commit
that referenced
this issue
Nov 18, 2020
This removes the requirement for <link rel="icon"> to fire load and error events, which no implementation followed. Closes #6122.
moz-v2v-gh
pushed a commit
to mozilla/gecko-dev
that referenced
this issue
Nov 26, 2020
…or <link rel="icon">, a=testonly Automatic update from web-platform-tests Test that no load or error events fire for <link rel="icon"> Test for whatwg/html#6122. -- wpt-commits: 43cb8f728ebfd5f312200d18bbe718fea62c1442 wpt-pr: 26557
sidvishnoi
pushed a commit
to sidvishnoi/gecko-webmonetization
that referenced
this issue
Nov 27, 2020
…or <link rel="icon">, a=testonly Automatic update from web-platform-tests Test that no load or error events fire for <link rel="icon"> Test for whatwg/html#6122. -- wpt-commits: 43cb8f728ebfd5f312200d18bbe718fea62c1442 wpt-pr: 26557
sylvestre
pushed a commit
to sylvestre/gecko-dev
that referenced
this issue
Nov 28, 2020
…or <link rel="icon">, a=testonly Automatic update from web-platform-tests Test that no load or error events fire for <link rel="icon"> Test for whatwg/html#6122. -- wpt-commits: 43cb8f728ebfd5f312200d18bbe718fea62c1442 wpt-pr: 26557
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
While trying to write some tests for #3483, I noticed that per the spec
<link rel="icon">
should fire aload
orerror
event, but none of the major browsers implement this, even when the icon is showing in the browser chrome.By the spec, the default process the linked resource algorithm fires the
load
anderror
events, but that algorithm only runs if all of these conditions hold:<link>
element represents an external resource linkrel="icon"
's "should be used by the user agent when representing the page in the user interface" counts here)The only currently defined link type that fulfills all of those conditions is
rel="icon"
, so it might be best to make the default process the linked resource algorithm a noop, though I'd be fine with defining custom process the linked resource steps forrel="icon"
. Other link types that fire theload
anderror
events, such asrel="stylesheet"
andrel="prefetch"
, do so in their overriden "process the linked resource" algorithms, and so aren't affected.See also web-platform-tests/wpt#21352, which points out the lack of tests.
The text was updated successfully, but these errors were encountered: