Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

redact location.ancestorOrigins according to parents referrer policies #1917

Closed

Conversation

hillbrad
Copy link

consider parent browsing context referrer policy state when assignin ancestorOrigins for a Location

@hillbrad
Copy link
Author

Addresses #1918

<li><p><i>Loop</i>: If <var>current</var> has no <span>parent browsing context</span>, jump to
the step labeled <i>end</i>.</p></li>

<li><p>Let <var>current</var> be <var>current</var>'s <span>parent browsing
context</span>.</p></li>

<li><p>Let <var>referrer</var> be the result of executing the steps to
<dfn data-x="determine-requests-referrer">determine a request's referrer</dfn>, using:</li>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This isn't an appropriate algorithm to use, as it takes a request, but there is no request in sight here. I think you need to create some algorithm, either here or in Referrer Policy, named "origin censored according to a referrer policy" that takes an origin and a referrer policy. Then pass it current's active document's referrer policy and current's active document's origin.

Also, what happens if it's completely censored? Does the array get a null in it? If so the IDL needs to change to FrozenArray<USVString?> and the prose needs to deal. Or does that entry simply not end up in the array?

@domenic domenic added normative change needs implementer interest Moving the issue forward requires implementers to express interest do not merge yet Pull request must not be merged per rationale in comment needs tests Moving the issue forward requires someone to write tests labels Oct 17, 2016
@domenic
Copy link
Member

domenic commented Oct 17, 2016

Although we should finish the discussion in #1918 first, this seems like something that it would be really good to have web-platform-tests for, before merging.

@domenic domenic added the security/privacy There are security or privacy implications label Oct 17, 2016
@hillbrad hillbrad closed this Oct 17, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
do not merge yet Pull request must not be merged per rationale in comment needs implementer interest Moving the issue forward requires implementers to express interest needs tests Moving the issue forward requires someone to write tests normative change security/privacy There are security or privacy implications
Development

Successfully merging this pull request may close these issues.

2 participants