Use Web IDL to construct custom element constructors #2457
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
domenic
added
do not merge yet
domenic
added a commit
to whatwg/dom
that referenced
this pull request
Mar 23, 2017
Fixes part of whatwg/html#2381. The other part is covered by whatwg/html#2457.
domenic
added a commit
to whatwg/dom
that referenced
this pull request
Mar 23, 2017
Fixes part of whatwg/html#2381. The other part is covered by whatwg/html#2457.
domenic
force-pushed
the
custom-element-construct
branch
from
7e0bb3f to
745cf0e
Compare
domenic
added a commit
to web-platform-tests/wpt
that referenced
this pull request
Mar 23, 2017
domenic
removed
the
needs tests
domenic
added a commit
to whatwg/dom
that referenced
this pull request
Mar 27, 2017
Fixes part of whatwg/html#2381. The other part is covered by whatwg/html#2457.
This fixes part of #2381 (the other part is in DOM's "create an element"). Note this has two consequences, as discussed there: * Properly managing the entry and incumbent concepts. This is technically unobservable in the current spec landscape. * Ensuring microtasks are run, if the construct is initiated with an empty stack (such as during the parser).
domenic
removed
the
do not merge yet
domenic
force-pushed
the
custom-element-construct
branch
from
745cf0e to
1feaaf7
Compare
|
This and its counterpart PRs in DOM and WPT are ready to merge. |
annevk
approved these changes
Mar 27, 2017
source
Outdated
| @@ -67013,7 +67017,9 @@ customElements.define("x-foo", class extends HTMLElement { | |||
|
|
|||
| <ol> | |||
| <li> | |||
| <p>Let <var>constructResult</var> be <span>Construct</span>(<var>C</var>).</p> | |||
| <p>Let <var>constructResult</var> be the result of <span | |||
| data-x="es-constructing-callback-functions">constructing</span> <var>C</var> with no | |||
There was a problem hiding this comment.
Comma before with? That's what whatwg/dom#430 does. LGTM with that.
domenic
added a commit
to whatwg/dom
that referenced
this pull request
Mar 28, 2017
Fixes part of whatwg/html#2381. The other part is covered by whatwg/html#2457. Tests: web-platform-tests/wpt#5208
domenic
added a commit
to web-platform-tests/wpt
that referenced
this pull request
Apr 24, 2017
foolip
pushed a commit
to web-platform-tests/wpt
that referenced
this pull request
Apr 25, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes part of #2381 (the other part is in DOM's "create an
element", and fixed by web-platform-tests/wpt#5208).
Tests: web-platform-tests/wpt#5208
This cannot be merged until whatwg/webidl#328 is also merged.