Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix #358: Use DOMTokenList exclusively #361

Merged
merged 1 commit into from
Jan 28, 2016
Merged

Fix #358: Use DOMTokenList exclusively #361

merged 1 commit into from
Jan 28, 2016

Conversation

zcorpan
Copy link
Member

@zcorpan zcorpan commented Nov 26, 2015

In whatwg/dom#120 the DOM spec merged DOMSettableTokenList into
DOMTokenList. Switch to DOMTokenList with [PutForwards=value]
for all instances that used DOMTokenList or DOMSettableTokenList.

Simplify the reflecting attributes prose involving DOMTokenList.

Issue: #358

@annevk annevk added the do not merge yet Pull request must not be merged per rationale in comment label Nov 26, 2015
This was referenced Dec 3, 2015
Closed
Merged
@zcorpan zcorpan mentioned this pull request Jan 28, 2016
Closed
zcorpan added a commit to web-platform-tests/wpt that referenced this pull request Jan 28, 2016
@zcorpan
Fix #2411: Merge DOMTokenList/DOMSettableTokenList
6d8ea3b 
Update tests for
whatwg/dom#120
whatwg/html#361
@zcorpan zcorpan mentioned this pull request Jan 28, 2016
Merged
@zcorpan @annevk
Fix #358: use DOMTokenList exclusively
98183f9 
In whatwg/dom#120 the DOM spec merged DOMSettableTokenList into
DOMTokenList. Switch to DOMTokenList with [PutForwards=value]
for all instances that used DOMTokenList or DOMSettableTokenList.

Simplify the reflecting attributes prose involving DOMTokenList.
@annevk
Copy link
Member

annevk commented Jan 28, 2016

Do we want to use PutForwards even when there is an attribute you can use to set the string instead? E.g., with rel/relList does the latter really need PutForwards?

@domenic
Copy link
Member

domenic commented Jan 28, 2016

I think so, for consistency. You can just teach people relList and forget about rel.

@annevk annevk merged commit 98183f9 into master Jan 28, 2016
@annevk
Copy link
Member

annevk commented Jan 28, 2016

Alrighty then.

@annevk annevk deleted the use-domtokenlist branch January 28, 2016 22:55
kisg pushed a commit to paul99/webkit-mips that referenced this pull request Feb 4, 2016
Merge DOMTokenList and DOMSettableTokenList
5863cc7 
https://bugs.webkit.org/show_bug.cgi?id=153677
<rdar://problem/24419675>

Reviewed by Sam Weinig.

LayoutTests/imported/w3c:

Rebaseline several W3C tests now that more checks are passing.

* web-platform-tests/dom/historical-expected.txt:
* web-platform-tests/dom/interfaces-expected.txt:
* web-platform-tests/dom/nodes/Element-classlist-expected.txt:
* web-platform-tests/html/dom/interfaces-expected.txt:

* web-platform-tests/html/dom/interfaces.html:
Update HTMLAreaElement.relList to match the specification.

Source/WebCore:

Merge DOMTokenList and DOMSettableTokenList, as per a recent
specification change:
- whatwg/dom#120
- whatwg/html#361

No new tests, already covered by existing tests.

* CMakeLists.txt:
* DerivedSources.cpp:
* WebCore.vcxproj/WebCore.vcxproj:
* WebCore.vcxproj/WebCore.vcxproj.filters:
* WebCore.xcodeproj/project.pbxproj:
* dom/Element.idl:
* dom/Node.h:
* dom/NodeRareData.h:
* html/AttributeDOMTokenList.h:
* html/DOMSettableTokenList.cpp: Removed.
* html/DOMSettableTokenList.h:
* html/DOMSettableTokenList.idl:
* html/DOMTokenList.cpp:
(WebCore::DOMTokenList::setValue):
* html/DOMTokenList.h:
* html/DOMTokenList.idl:
* html/HTMLAnchorElement.idl:
* html/HTMLAreaElement.idl:
* html/HTMLElement.cpp:
* html/HTMLElement.idl:
* html/HTMLIFrameElement.cpp:
(WebCore::HTMLIFrameElement::sandbox):
* html/HTMLIFrameElement.h:
* html/HTMLIFrameElement.idl:
* html/HTMLLinkElement.cpp:
(WebCore::HTMLLinkElement::sizes):
* html/HTMLLinkElement.h:
* html/HTMLLinkElement.idl:
* html/HTMLOutputElement.cpp:
(WebCore::HTMLOutputElement::htmlFor):
* html/HTMLOutputElement.h:
* html/HTMLOutputElement.idl:
* html/HTMLTableCellElement.idl:
* page/DOMWindow.cpp:
* page/DOMWindow.idl:

LayoutTests:

Update / rebaseline several tests now that relList attributes
use [PutForward=value].

* fast/dom/HTMLElement/class-list-expected.txt:
* fast/dom/HTMLElement/class-list-quirks-expected.txt:
* fast/dom/HTMLElement/script-tests/class-list.js:
* fast/dom/rel-list-expected.txt:
* fast/dom/rel-list.html:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@196123 268f45cc-cd09-0410-ab3c-d52691b4dbfc
ryanhaddad pushed a commit to WebKit/WebKit that referenced this pull request Dec 22, 2020
@cdumez
Merge DOMTokenList and DOMSettableTokenList
cd0ec66 
https://bugs.webkit.org/show_bug.cgi?id=153677
<rdar://problem/24419675>

Reviewed by Sam Weinig.

LayoutTests/imported/w3c:

Rebaseline several W3C tests now that more checks are passing.

* web-platform-tests/dom/historical-expected.txt:
* web-platform-tests/dom/interfaces-expected.txt:
* web-platform-tests/dom/nodes/Element-classlist-expected.txt:
* web-platform-tests/html/dom/interfaces-expected.txt:

* web-platform-tests/html/dom/interfaces.html:
Update HTMLAreaElement.relList to match the specification.

Source/WebCore:

Merge DOMTokenList and DOMSettableTokenList, as per a recent
specification change:
- whatwg/dom#120
- whatwg/html#361

No new tests, already covered by existing tests.

* CMakeLists.txt:
* DerivedSources.cpp:
* WebCore.vcxproj/WebCore.vcxproj:
* WebCore.vcxproj/WebCore.vcxproj.filters:
* WebCore.xcodeproj/project.pbxproj:
* dom/Element.idl:
* dom/Node.h:
* dom/NodeRareData.h:
* html/AttributeDOMTokenList.h:
* html/DOMSettableTokenList.cpp: Removed.
* html/DOMSettableTokenList.h:
* html/DOMSettableTokenList.idl:
* html/DOMTokenList.cpp:
(WebCore::DOMTokenList::setValue):
* html/DOMTokenList.h:
* html/DOMTokenList.idl:
* html/HTMLAnchorElement.idl:
* html/HTMLAreaElement.idl:
* html/HTMLElement.cpp:
* html/HTMLElement.idl:
* html/HTMLIFrameElement.cpp:
(WebCore::HTMLIFrameElement::sandbox):
* html/HTMLIFrameElement.h:
* html/HTMLIFrameElement.idl:
* html/HTMLLinkElement.cpp:
(WebCore::HTMLLinkElement::sizes):
* html/HTMLLinkElement.h:
* html/HTMLLinkElement.idl:
* html/HTMLOutputElement.cpp:
(WebCore::HTMLOutputElement::htmlFor):
* html/HTMLOutputElement.h:
* html/HTMLOutputElement.idl:
* html/HTMLTableCellElement.idl:
* page/DOMWindow.cpp:
* page/DOMWindow.idl:

LayoutTests:

Update / rebaseline several tests now that relList attributes
use [PutForward=value].

* fast/dom/HTMLElement/class-list-expected.txt:
* fast/dom/HTMLElement/class-list-quirks-expected.txt:
* fast/dom/HTMLElement/script-tests/class-list.js:
* fast/dom/rel-list-expected.txt:
* fast/dom/rel-list.html:

Canonical link: https://commits.webkit.org/171969@main
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@196123 268f45cc-cd09-0410-ab3c-d52691b4dbfc
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
do not merge yet Pull request must not be merged per rationale in comment
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@zcorpan @annevk @domenic