-
Notifications
You must be signed in to change notification settings - Fork 2.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add the ability to queue an element task. #5072
Conversation
The event loop and the document source are attributed to the element's node document and relevant realm. Fixes whatwg#4980
@domenic, Yoav was asking about the status of the spec changes here. I think this is still pending your review.. Might need to rebase it though. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I pushed some tweaks and this looks good to me now. However it does not close #4980 as there are still 200 uses of "queue a task"; this just converts a couple as a sample.
Is the plan to continue iterating in this pull request, or do follow-ups? I'd like to not do 200 pull requests, but somewhere between 1 and 5 seems reasonable...
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I was planning on making it a few pull requests something that is manageable to write and review. Certainly not 200. But I wanted to get the framework in place first. Hmm.. perhaps this should be queue a node task, and then we get it for free for using it for document targets. WDYT?
Hmm. I guess that seems a little weird as a lot of the tasks don't seem to be "node tasks", i.e. they're not very DOM-related. Perhaps instead we could change the normal "queue a task" to use the document to compute the event loop, if the document is given? |
I think probably using the queue a task will probably be just more natural. So let's leave this as queue an element task. |
The event loop and the document source are attributed to the element's
node document and relevant realm.
Fixes #4980
/images.html ( diff )
/webappapis.html ( diff )