Code

Import assertions integration#5883

Code

Closed

dandclark wants to merge 44 commits intowhatwg:mainwhatwg/html:mainfrom dandclark:dandclark/import-attributes-no-jsondandclark/html:dandclark/import-attributes-no-jsonCopy head branch name to clipboard

+191-87

Commits

Commits on Jun 19, 2020

• Reland JSON modules

  Show description for 914e7d5
  dandclark

  committed
  914e7d5

  Copy full SHA for 914e7d5

• Add import attribute type checks and initial plumbing.

  Show description for b058240
  dandclark

  committed
  b058240

  Copy full SHA for b058240

• Plumb through ModuleRequest instead of string for 'fetch an import() module script graph', HostResolveImportedModule, and HostResolveImportedModuleDynamically.

  dandclark

  committed
  d0137f5

  Copy full SHA for d0137f5

• Don't cache a null entry in the module map in the case where the MIME type is valid but doesn't match the requested type.

  dandclark

  committed
  b2e7065

  Copy full SHA for b2e7065

• Allow modulepreload to work for all module types without needing to specify type at the point of preload. Achieve this by adding 'module type must match' flag to 'fetch a single module script', whi…

  Show description for 0cbf597
  dandclark

  committed
  0cbf597

  Copy full SHA for 0cbf597

• After rebase, fix build break from name change to JSON.Parse in whatwg@b1078ae

  dandclark

  committed
  6932074

  Copy full SHA for 6932074

Commits on Jun 22, 2020

• Fix typo in JSON modules example and add note on requiring JSON MIME type.

  dandclark

  committed
  1f83c7e

  Copy full SHA for 1f83c7e

• Update ModuleRequest definition to reference the import-attributes proposal spec

  dandclark

  committed
  a3621dd

  Copy full SHA for a3621dd

• Revert added null check in 'fetch a modulepreload module script graph'; I'll add this in a separate PR.

  dandclark

  committed
  55ebd12

  Copy full SHA for 55ebd12

• Reference ParseJSONModule from import-attributes proposal instead of defining steps in HTML spec

  dandclark

  committed
  af41b28

  Copy full SHA for af41b28

Commits on Jun 23, 2020

• Cache an entry in the module map if the fetched module was valid but does not match the type specified at the import site.

  dandclark

  committed
  a2d4260

  Copy full SHA for a2d4260

• Extend note to be clear that the module must have no effect until a request matches its type and it is evalutated

  dandclark

  committed
  f79c01f

  Copy full SHA for f79c01f

Commits on Jun 25, 2020

• When a valid MIME type is received that doesn't match the requested type, cache the fetch response instead of creating and caching the module script. The module script is created only when there is…

  Show description for 7c900a1
  dandclark

  committed
  7c900a1

  Copy full SHA for 7c900a1

Commits on Jun 26, 2020

• Wrap <p class=note> in <li> so it's not directly under an <ol>, which the Travis CI build doesn't like.

  dandclark

  committed
  55c9ed9

  Copy full SHA for 55c9ed9

• Whitespace change: remove double spaces after sentences in notes. Hopefully unstick CI build, which seems to be stuck.

  dandclark

  committed
  322808d

  Copy full SHA for 322808d

Commits on Jun 30, 2020

• Merge branch 'upstream-master' into dandclark/import-attributes

  Show description for 43e6fe3
  dandclark

  committed
  43e6fe3

  Copy full SHA for 43e6fe3

• Reword invocations of 'create a module script with matching type' to ensure they are synchronous with respect to the calling 'fetch a single module script'

  dandclark

  committed
  9f2ae27

  Copy full SHA for 9f2ae27

• Change 'fetch a single module script' to fail if there are any unrecognized import attributes, and assert that there is only one of key 'type' (which should be guaranteed by Ecma262)

  dandclark

  committed
  e86dd65

  Copy full SHA for e86dd65

Commits on Jul 7, 2020

• Instead of passing fetch response parameter to 'create a module script with matching type', retrieve it from the module map within the algorithm.

  dandclark

  committed
  3318ed3

  Copy full SHA for 3318ed3

• Add assert that 'create a module script with matching type' is not running in parallel

  dandclark

  committed
  3c0dce2

  Copy full SHA for 3c0dce2

Commits on Jul 8, 2020

• Reword caching comment

  dandclark

  committed
  1c9df5a

  Copy full SHA for 1c9df5a

Commits on Jul 9, 2020

• Handle rename in TC39 proposal from import attributes to import conditions

  dandclark

  committed
  3247e99

  Copy full SHA for 3247e99

Commits on Jul 24, 2020

• Update for the latest rename of the proposal from 'Import Conditions' to 'Import Assertions'

  dandclark

  committed
  dca376b

  Copy full SHA for dca376b

Commits on Jul 27, 2020

• Use module type as part of module map cache key instead of caching response body in the case of a failed type check.

  dandclark

  committed
  e3359b5

  Copy full SHA for e3359b5

Commits on Aug 27, 2020

• Merge remote-tracking branch 'upstream/master' into dandclark/import-attributes

  dandclark

  committed
  0857ec8

  Copy full SHA for 0857ec8

• Change 'abort these steps' to 'return' to match recent changes in 'fetch a single module script'.

  dandclark

  committed
  aafb256

  Copy full SHA for aafb256

Commits on Aug 31, 2020

• Remove JSON modules references, switch JavaScript module script references back to just 'module script'

  dandclark

  committed
  9164acf

  Copy full SHA for 9164acf

Commits on Sep 30, 2020

• Merge remote-tracking branch 'upstream/master' into dandclark/import-attributes-no-json

  dandclark

  committed
  f53c203

  Copy full SHA for f53c203

• Update module map dfn note to explain purpose of having module type in key, and that in practice fetches and module evalutations will only occur once per specifier

  dandclark

  committed
  73f2be2

  Copy full SHA for 73f2be2

• Ignore unknown import assertions instead of failing. Continue failing for unrecognized types (which is to say, any type at all).

  dandclark

  committed
  6ed4474

  Copy full SHA for 6ed4474

Commits on Oct 5, 2020

• Move check for unknown type assertion to 'create a module script'.

  dandclark

  committed
  c225d56

  Copy full SHA for c225d56

Commits on Nov 12, 2020

• Merge remote-tracking branch 'upstream/master' into dandclark/import-attributes-no-json

  dandclark

  committed
  1566bc0

  Copy full SHA for 1566bc0

• Review feedback: use tuple instead of pair, improve module map definition, use 'javascript' instead of undefined, fix indents.

  dandclark

  committed
  3c94b31

  Copy full SHA for 3c94b31

Commits on Nov 13, 2020

• Review feedback: Link to memory cache issue, null --> 'javascript' type, misc whitespace issues.

  dandclark

  committed
  9da92b5

  Copy full SHA for 9da92b5

• Remove duplicated words

  dandclark

  committed
  26c2b81

  Copy full SHA for 26c2b81

Commits on Nov 16, 2020

• Move quotes outside of <code> elements.

  dandclark

  committed
  4ad7d2d

  Copy full SHA for 4ad7d2d

Commits on Nov 30, 2020

• Add HostGetSupportedAssertions integration

  dandclark

  committed
  614a9f4

  Copy full SHA for 614a9f4

Commits on Dec 1, 2020

• Fix indentation/spacing. Use short list notation.

  dandclark

  committed
  2fc3616

  Copy full SHA for 2fc3616

Commits on Dec 11, 2020

• Merge remote-tracking branch 'upstream/master' into dandclark/import-attributes-no-json

  dandclark

  committed
  697a6f1

  Copy full SHA for 697a6f1

Commits on Dec 29, 2020

• Use two separate scripts in example so that at least one will actually evaluate

  dandclark

  committed
  a9eed9b

  Copy full SHA for a9eed9b

• Add module type to visited set.

  dandclark

  committed
  973ec71

  Copy full SHA for 973ec71

Commits on Dec 31, 2020

• Clarify that memory cache mitigating violation of import assertions spec recommendation is not a sure thing.

  dandclark

  committed
  fdc08f8

  Copy full SHA for fdc08f8

Commits on Mar 10, 2021

• Merge remote-tracking branch 'upstream/main' into dandclark/import-attributes-no-json

  dandclark

  committed
  30e27fb

  Copy full SHA for 30e27fb

Commits on Mar 11, 2021

• Add class='XXX' to note about the memory cache

  dandclark

  committed
  9ec7c7e

  Copy full SHA for 9ec7c7e