Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adding [SameObject] to DOMTokenLists #700

Closed
wants to merge 1 commit into from
Closed

Adding [SameObject] to DOMTokenLists #700

wants to merge 1 commit into from

Conversation

Ritsyy
Copy link
Contributor

@Ritsyy Ritsyy commented Feb 16, 2016

Fix #580.

annevk
annevk reviewed Feb 16, 2016
View reviewed changes
source
@@ -8945,7 +8945,7 @@ partial /*sealed*/ interface <dfn>Document</dfn> {
attribute DOMString <span data-x="dom-accessKey">accessKey</span>;
readonly attribute DOMString <span data-x="dom-accessKeyLabel">accessKeyLabel</span>;
attribute boolean <span data-x="dom-draggable">draggable</span>;
[PutForwards=<span data-x="dom-DOMTokenList-value">value</span>] readonly attribute <span>DOMTokenList</span> <span data-x="dom-dropzone">dropzone</span>;
[PutForwards=<span data-x="dom-DOMTokenList-value">value</span>] [SameObject] readonly attribute <span>DOMTokenList</span> <span data-x="dom-dropzone">dropzone</span>;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we want to copy the DOM Standard here and use [SameObject, PutForwards=value].

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes you are right, thanks.

@zcorpan
Copy link
Member

zcorpan commented Feb 16, 2016

Remove "The same DOMTokenList object must be returned every time for each attribute." in #reflect

@domenic domenic added the clarification Standard could be clearer label Feb 16, 2016
@annevk
Copy link
Member

annevk commented Feb 17, 2016

Committed as ec1dc4d. Thank you @Ritsyy!

@annevk annevk closed this Feb 17, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
clarification Standard could be clearer
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Ritsyy @zcorpan @annevk @domenic