Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for subframes navigations ending up in an ASSERT. #7398

Merged
merged 2 commits into from
Dec 8, 2021
Merged

Fix for subframes navigations ending up in an ASSERT. #7398

merged 2 commits into from
Dec 8, 2021

Conversation

hemeryar
Copy link
Member

@hemeryar hemeryar commented Dec 8, 2021

Tiny fix for issue #7380, we have an assert that will fail for any subframe navigation. Probably ended up in that state after successive COOP changes.


💥 Error: Wattsi server error 💥

PR Preview failed to build. (Last tried on Dec 8, 2021, 9:20 AM UTC).

More

PR Preview relies on a number of web services to run. There seems to be an issue with the following one:

🚨 Wattsi Server - Wattsi Server is the web service used to build the WHATWG HTML spec.

🔗 Related URL

<html>
<head><title>524 Origin Time-out</title></head>
<body bgcolor="white">
<center><h1>524 Origin Time-out</h1></center>
<hr><center>cloudflare-nginx</center>
</body>
</html>

If you don't have enough information above to solve the error by yourself (or to understand to which web service the error is related to, if any), please file an issue.

@hemeryar hemeryar changed the title Assert fix Fix for subframes navigations ending up in an ASSERT. Dec 8, 2021
@hemeryar
Copy link
Member Author

hemeryar commented Dec 8, 2021

Note this is building fine, PR preview fail looks like an infra failure.

@domenic domenic added topic: frames/navigables/browsing contexts topic: cross-origin-opener-policy Issues and ideas around the new "inverse of rel=noopener" header labels Dec 8, 2021
@domenic domenic merged commit 0e49b8c into whatwg:main Dec 8, 2021
@hemeryar hemeryar deleted the assert_fix branch March 29, 2022 16:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Development

Successfully merging this pull request may close these issues.

2 participants