Redo validation errors in the IPv4 parser #739
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ab0e820 didn't consider the impact on the validation error infrastructure. This also makes some minor additional changes: * Modernizes the "Host parsing" section. * Clarifies that the IPv4 parser cannot be invoked directly. * Clarifies that the IPv6 parser can, but you should still not do it. Fixes #706.
Merged
|
This looks sensible to me. |
domenic
approved these changes
Jan 19, 2023
| reporting them before we are confident we want to parse <var>input</var> as an IPv4 address as the | ||
| <a>host parser</a> almost always invokes the <a>IPv4 parser</a>. | ||
| <p class=note>The <a for=/>IPv4 parser</a> is not to be invoked directly. Instead check that the | ||
| return value of the <a for=/>host parser</a> is an <a for=/>IPv4 address</a>. |
There was a problem hiding this comment.
I don't understand why IPv4 and IPv6 would be different...
There was a problem hiding this comment.
The host parser does percent-decoding and ToASCII before determining if something is an IPv4 address. The only thing it does before IPv6 is removing square brackets. In practice though I think people should always use the host parser and therefore neither the IPv4 nor the IPv6 parser are exported.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ab0e820 didn't consider the impact on the validation error infrastructure.
This also makes some minor additional changes:
Fixes #706.
Preview | Diff