Fix and simplify MDN annotations #91
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Always search for the nearest <body> child and insert before it.
|
Coincidentally, I'm getting folks contacting me about the broken build right now while trying to build HTML, so let me go ahead and merge... |
Yeah — thanks for doing that But will still take some time now to test it |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Always search for the nearest
<body>child and insert before it.@sideshowbarker, this removes a decent amount of the work you did, so I'm not sure I did it right. It's certainly simpler, but probably worse in various ways.
Still, it's right in the key way that if you run
in the dev console, you get
1, whereas on https://arcane-cove-57093.herokuapp.com/ it gives3.I think we should probably merge this right away to un-break the build, but let me know if you disagree.