Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Require new for named constructors #275

Closed
domenic opened this issue Jan 23, 2017 · 3 comments
Closed

Require new for named constructors #275

domenic opened this issue Jan 23, 2017 · 3 comments

Comments

@domenic
Copy link
Member

domenic commented Jan 23, 2017

At least Gecko and Blink require new for them. Edge does not, but Edge also does not require new for un-named constructors.

We should test Safari TP to be sure, but it seems like things have moved in this direction, even though to me it would be OK for "named constructors" to not require new since they're fancy factory functions in disguise.
@tobie
Copy link
Collaborator

tobie commented Jan 23, 2017

How does one require new. With a NewTarget that's not undefined?

@domenic
Copy link
Member Author

domenic commented Jan 23, 2017

Yep, exactly, like https://heycam.github.io/webidl/#es-constructible-interfaces step 2

@bzbarsky
Copy link
Collaborator

I can't tell you about Safari TP, but in WebKit nightly requires new on both constructors and namedconstructors. So Edge is the odd engine out here.

@tobie tobie mentioned this issue Jan 24, 2017
Closed
tobie added a commit to tobie/webidl that referenced this issue Jan 24, 2017
@tobie
Revamp interface object bindings.
76e50d0 
* Extract legacy callback interface objects
  out of interface objects. Closes whatwg#78.
* Clarify that legacy callback interfaces are function objects.
* Give them a length property. Closes whatwg#279. Closes whatwg#83.
* Require new for Named Constructors. Closes whatwg#275.
* Rely on ES abstract operations for defining,
  named constructors, interface objects, and
  legacy callback interface objects.
* Disallow using the [NoInterfaceObject] on
  callback interfaces with constants.
tobie added a commit to tobie/webidl that referenced this issue Jan 24, 2017
@tobie
Revamp interface bindings
c04bd37 
* Extract legacy callback interface objects
  out of interface objects. Closes whatwg#78.
* Clarify that legacy callback interfaces are function objects.
* Give them a length property. Closes whatwg#279. Closes whatwg#83.
* Require new for Named Constructors. Closes whatwg#275.
* Rely on ES abstract operations for defining,
  named constructors, interface objects, and
  legacy callback interface objects.
* Disallow using the [NoInterfaceObject] on
  callback interfaces with constants.
@tobie tobie mentioned this issue Jan 24, 2017
Closed
tobie added a commit to tobie/webidl that referenced this issue Feb 14, 2017
@tobie
Revamp interface bindings
8c8c143 
* Extract legacy callback interface objects
  out of interface objects. Closes whatwg#78.
* Clarify that legacy callback interfaces are function objects.
* Give them a length property. Closes whatwg#279. Closes whatwg#83.
* Require new for Named Constructors. Closes whatwg#275.
* Rely on ES abstract operations for defining,
  named constructors, interface objects, and
  legacy callback interface objects.
* Disallow using the [NoInterfaceObject] on
  callback interfaces with constants.
tobie added a commit to tobie/webidl that referenced this issue Feb 20, 2017
@tobie
Revamp interface bindings
f3fa480 
* Extract legacy callback interface objects
  out of interface objects. Closes whatwg#78.
* Clarify that legacy callback interfaces are function objects.
* Give them a length property. Closes whatwg#279. Closes whatwg#83.
* Require new for Named Constructors. Closes whatwg#275.
* Rely on ES abstract operations for defining,
  named constructors, interface objects, and
  legacy callback interface objects.
* Disallow using the [NoInterfaceObject] on
  callback interfaces with constants.
@tobie tobie mentioned this issue Feb 20, 2017
Merged
tobie added a commit to tobie/webidl that referenced this issue Feb 20, 2017
@tobie
Revamp interface bindings
fe1e2cd 
* Extract legacy callback interface objects
  out of interface objects. Closes whatwg#78.
* Clarify that legacy callback interfaces are function objects.
* Give them a length property. Closes whatwg#279. Closes whatwg#83.
* Require new for Named Constructors. Closes whatwg#275.
* Rely on ES abstract operations for defining,
  named constructors, interface objects, and
  legacy callback interface objects.
* Disallow using the [NoInterfaceObject] on
  callback interfaces with constants.
tobie added a commit that referenced this issue Feb 20, 2017
@tobie
Revamp interface bindings (#313)
4a8f57e 
* Extract legacy callback interface objects
  out of interface objects. Closes #78.
* Clarify that legacy callback interfaces are function objects.
* Give them a length property. Closes #279. Closes #83.
* Require new for Named Constructors. Closes #275.
* Rely on ES abstract operations for defining
  named constructors, interface objects, and
  legacy callback interface objects.
* Disallow using [NoInterfaceObject] on
  callback interfaces with constants.
* Don't require an interface prototype object for constants.
  Callback interfaces do not have an interface prototype object.
  Their constants sit on the legacy callback interface object itself.
  Closes #281.

Closes #283.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@tobie @domenic @bzbarsky