Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rename "named constructors" #277

Closed
domenic opened this issue Jan 23, 2017 · 4 comments
Closed

Rename "named constructors" #277

domenic opened this issue Jan 23, 2017 · 4 comments
Assignees
@domenic
Labels
⌛⌛ duration:medium Shouldn't be too long to fix good first issue Ideal for someone new to a WHATWG standard or software project

Comments

@domenic
Copy link
Member

domenic commented Jan 23, 2017

  1. They are a legacy feature
  2. They are not constructors

Since this is apparently only used by HTML (can someone confirm?) it should be an easy rename.

I'm thinking "LegacyFactoryFunction"? And the whole feature should be renamed "legacy factory functions".
@bzbarsky
Copy link
Collaborator

They are not constructors

In what sense are they not constructors? They're constructors; they just happen to not be named the same as the interface is named...

@domenic
Copy link
Member Author

domenic commented Jan 23, 2017

I guess they pass the IsConstructor() check, that's true. But so does function F() { }.

I meant it in the sense of them not being "the" constructor for a class. The one returned by prototype.constructor and such.

@tobie
Copy link
Collaborator

tobie commented Jan 24, 2017

This also implies renaming the extended attribute, right?

@tobie tobie added ⌛⌛ duration:medium Shouldn't be too long to fix good first issue Ideal for someone new to a WHATWG standard or software project labels Jan 24, 2017
@annevk
Copy link
Member

annevk commented Jan 25, 2017

Yeah, "LegacyFactoryFunction" is the suggestion for that.

@domenic domenic mentioned this issue May 11, 2017
Closed
@domenic domenic self-assigned this Apr 8, 2020
domenic added a commit that referenced this issue Apr 8, 2020
@domenic
Rename "named constructors" to "legacy factory functions"
196ed9e 
Closes #277. This includes renaming the extended attribute, which is part of #350.

Also, since we don't anticipate this being used again, we remove the zero-argument form, which has no current users.

As a bonus, this removes some leftover references to "constructor extended attributes".
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@domenic domenic

Labels
⌛⌛ duration:medium Shouldn't be too long to fix good first issue Ideal for someone new to a WHATWG standard or software project
Milestone
No milestone
Development

No branches or pull requests
4 participants
@tobie @domenic @bzbarsky @annevk