Qvalent: Map CVV Result to responses

Closes activemerchant#3135

Remote:
19 tests, 63 assertions, 0 failures, 0 errors, 0 pendings, 0 omissions, 0 notifications
100% passed

Unit:
18 tests, 86 assertions, 0 failures, 0 errors, 0 pendings, 0 omissions, 0 notifications
100% passed

CHANGELOG

@@ -23,6 +23,7 @@
 * NMI: Add customer id to authorization on store [curiousepic] #3130
 * Trans First Express: Don't pass blank name field [curiousepic] #3133
 * TrustCommerce: Send full name on ACH transactions [jknipp] #3132
+* Qvalent: Map CVV Result to responses [curiousepic] #3135
 
 == Version 1.90.0 (January 8, 2019)
 * Mercado Pago: Support "gateway" processing mode [curiousepic] #3087

lib/active_merchant/billing/gateways/qvalent.rb

@@ -12,6 +12,10 @@ class QvalentGateway < Gateway
       self.money_format = :cents
       self.supported_cardtypes = [:visa, :master, :american_express, :discover, :jcb, :diners]
 
+      CVV_CODE_MAPPING = {
+        'S' => 'D'
+      }
+
       def initialize(options={})
         requires!(options, :username, :password, :merchant, :pem, :pem_password)
         super
@@ -168,11 +172,18 @@ def commit(action, post)
           message_from(succeeded, raw),
           raw,
           authorization: raw['response.orderNumber'] || raw['response.customerReferenceNumber'],
+          cvv_result: cvv_result(succeeded, raw),
           error_code: error_code_from(succeeded, raw),
           test: test?
         )
       end
 
+      def cvv_result(succeeded, raw)
+        return unless succeeded
+        code = CVV_CODE_MAPPING[raw['response.cvnResponse']] || raw['response.cvnResponse']
+        CVVResult.new(code)
+      end
+
       def headers
         {
           'Content-Type'  => 'application/x-www-form-urlencoded'

test/remote/gateways/remote_qvalent_test.rb

@@ -25,7 +25,7 @@ def test_invalid_login
       pem_password: 'bad'
     )
 
-    assert_raise ActiveMerchant::ClientCertificateError do
+    assert_raise OpenSSL::X509::CertificateError do
       gateway.purchase(@amount, @credit_card, @options)
     end
   end

test/unit/gateways/qvalent_test.rb

@@ -24,6 +24,7 @@ def test_successful_purchase
     assert_success response
 
     assert_equal '5d53a33d960c46d00f5dc061947d998c', response.authorization
+    assert_equal 'M', response.cvv_result['code']
     assert response.test?
   end
 
@@ -186,6 +187,15 @@ def test_3d_secure_fields
     assert_success response
   end
 
+  def test_cvv_result
+    response = stub_comms do
+      @gateway.purchase(@amount, @credit_card)
+    end.respond_with(mapped_cvv_response)
+
+    assert_success response
+    assert_equal 'D', response.cvv_result['code']
+  end
+
   def test_transcript_scrubbing
     assert_equal scrubbed_transcript, @gateway.scrub(transcript)
   end
@@ -194,7 +204,8 @@ def test_transcript_scrubbing
 
   def successful_purchase_response
     %(
-      response.summaryCode=0\r\nresponse.responseCode=08\r\nresponse.text=Honour with identification\r\nresponse.referenceNo=723907124\r\nresponse.orderNumber=5d53a33d960c46d00f5dc061947d998c\r\nresponse.RRN=723907124   \r\nresponse.settlementDate=20150228\r\nresponse.transactionDate=28-FEB-2015 09:34:15\r\nresponse.cardSchemeName=VISA\r\nresponse.creditGroup=VI/BC/MC\r\nresponse.previousTxn=0\r\nresponse.end\r\n
+      response.summaryCode=0\r\nresponse.responseCode=08\r\nresponse.text=Honour with identification\r\nresponse.referenceNo=723907124\r\nresponse.orderNumber=5d53a33d960c46d00f5dc061947d998c\r\nresponse.RRN=723907124   \r\nresponse.settlementDate=20150228\r\nresponse.transactionDate=28-FEB-2015 09:34:15\r\nresponse.cardSchemeName=VISA\r\nresponse.creditGroup=VI/BC/MC\r\nresponse.previousTxn=0\r\nresponse.cvnResponse=M
+\r\nresponse.end\r\n
     )
   end
 
@@ -281,6 +292,13 @@ def empty_purchase_response
     )
   end
 
+  def mapped_cvv_response
+    %(
+      response.summaryCode=0\r\nresponse.responseCode=08\r\nresponse.text=Honour with identification\r\nresponse.referenceNo=723907124\r\nresponse.orderNumber=5d53a33d960c46d00f5dc061947d998c\r\nresponse.RRN=723907124   \r\nresponse.settlementDate=20150228\r\nresponse.transactionDate=28-FEB-2015 09:34:15\r\nresponse.cardSchemeName=VISA\r\nresponse.creditGroup=VI/BC/MC\r\nresponse.previousTxn=0\r\nresponse.cvnResponse=S
+\r\nresponse.end\r\n
+    )
+  end
+
   def transcript
     %(
 opening connection to ccapi.client.support.qvalent.com:443...