-
Notifications
You must be signed in to change notification settings - Fork 92
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Dev test #177
Dev test #177
Conversation
msimerson
commented
Apr 4, 2024
•
edited
Loading
edited
- test: switch runner from mocha to node builtin
- test: remove useless done
- they are only required for callback style async tests
- pkg: rm .travis.yml
- ci: update test runners
- ci: automatically test node LTS versions
- ci: update lint workflow
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for picking this up!
Several changes here:
|
- test: remove useless done - they are only required for callback style async tests - test: move test file into lib - pkg: rm .travis.yml - ci: update test runners - ci: automatically test LTS versions - ci: update lint workflow
Something I just thought of and don't like, is that putting the test file in lib publishes it on npm. That's a small deal, but with 36m weekly downloads, the smallness has a very large multiplier. I've talked myself out of it. 😲 Sorry for the noise. Note to self: the NPM docs say that putting a .npmignore in a subdirectory will override [files], so one could |
Thanks! |