Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

New 3.2.6 Release #1043

Closed
dgollahon opened this issue Oct 31, 2024 · 2 comments · Fixed by #1044
Closed

New 3.2.6 Release #1043

dgollahon opened this issue Oct 31, 2024 · 2 comments · Fixed by #1044

Comments

@dgollahon
Copy link
Contributor

I noticed that 3.2.6 is out. Can we get a release to suppress the typical incompatible version warning that I expect would arise?

As a note, would it be possible to make the warning less sensitive to patch releases?
koic added a commit to koic/parser that referenced this issue Oct 31, 2024
@koic
* Bump maintenance branches to 3.2.6
8e8f981 
Closes whitequark#1043.

Ruby 3.2.6 has been released:
https://www.ruby-lang.org/en/news/2024/10/30/ruby-3-2-6-released/

Bump 3.2 branch from 3.2.5 to 3.2.6:
ruby/ruby@v3_2_5...v3_2_6

There seems to be no change to the syntax.
@koic koic mentioned this issue Oct 31, 2024
Merged
iliabylich pushed a commit that referenced this issue Oct 31, 2024
@koic
* Bump maintenance branches to 3.2.6 (#1044)
cde8a96 
Closes #1043.

Ruby 3.2.6 has been released:
https://www.ruby-lang.org/en/news/2024/10/30/ruby-3-2-6-released/

Bump 3.2 branch from 3.2.5 to 3.2.6:
ruby/ruby@v3_2_5...v3_2_6

There seems to be no change to the syntax.
@iliabylich
Copy link
Collaborator

As a note, would it be possible to make the warning less sensitive to patch releases?

I think it makes sense, MRI had backward-incompatible grammar changes in patch releases in the past, so we have to "respect" it.

@dgollahon
Copy link
Contributor Author

I think it makes sense, MRI had backward-incompatible grammar changes in patch releases in the past, so we have to "respect" it.

I would also be happy with an opt-in "ignore_patch_warnings" option or something like that. I know it can occur but it's rare and I would like to silence it instead of waiting on a parser release (or having to do some by-hand) filtering.

Not a huge deal though and thanks for the quick release @koic!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

* Bump maintenance branches to 3.2.6 koic/parser
2 participants
@iliabylich @dgollahon