Follow "Separate Keyword Arguments from Positional Arguments" #607
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Follow ruby/ruby#2395. RuboCop's CI of Ruby 2.7 matrix is failing. This is due to a deprecation warning in Ruby 2.7. ```console 1) RuboCop::CLI when BlockDelimiters has braces_for_chaining style corrects SpaceBeforeBlockBraces, SpaceInsideBlockBraces offenses Failure/Error: expect($stderr.string).to eq('') expected: "" got: "/usr/local/bundle/gems/parser-2.6.4.0/lib/parser/source/tree_rewriter.rb:284: warning: The last argu...parser-2.6.4.0/lib/parser/source/tree_rewriter.rb:288: warning: for `trigger_policy' defined here\n" ``` https://circleci.com/gh/rubocop-hq/rubocop/67195 This PR suppress the following Ruby 2.7's warning. ```console % cd path/to/parser % bundle exec rake (snip) /Users/koic/src/github.com/whitequark/parser/lib/parser/source/tree_rewriter.rb:284: warning: The last argument for `trigger_policy' (defined at /Users/koic/src/github.com/whitequark/parser/lib/parser/source/tree_rewriter.rb:288) is used as the keyword parameter ```
koic
force-pushed
the
separate_kwargs_from_positional_args
branch
from
d2c8e28 to
f3cd9e5
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow ruby/ruby#2395.
RuboCop's CI of Ruby 2.7 matrix is failing. This is due to a deprecation warning in Ruby 2.7.
https://circleci.com/gh/rubocop-hq/rubocop/67195
This PR suppress the following Ruby 2.7's warning.