Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extend transaction timeout when new data is received #24

Open
whizzosoftware opened this issue Dec 28, 2017 · 4 comments
Open

Extend transaction timeout when new data is received #24

whizzosoftware opened this issue Dec 28, 2017 · 4 comments
Assignees

Comments

@whizzosoftware
Copy link
Owner

whizzosoftware commented Dec 28, 2017

When WZWave starts a transaction, it sets the timeout to be an absolute number of seconds from the point that data is sent. There has been cases where seriously slow responses are partially received but the transaction times out before the complete response can be sent.

Ideally, the transaction timeout should be extended when partial data is received to compensate for slow data coming from the PC controller.

@whizzosoftware
Copy link
Owner Author

@anton-johansson: when you have a chance, could you try the code from branch issue-24 to see if you can reproduce the issue you reported in #18? The branch contains fixes for both #24 and #25. Thanks!

@anton-johansson
Copy link
Contributor

I will take a look when I get home from work, later today!

@anton-johansson
Copy link
Contributor

Okay, so I did some runs with the changes in branch issue-24. I did 7 runs, and exactly every other one gave no errors, while the rest gave errors:

  1. No errors reported.
  2. Some errors reported, see output.
  3. No errors reported.
  4. Errors reported, pretty much identical to errors in step 2, see output.
  5. No errors reported.
  6. Errors reported, similar to step 2 and 4, but not exactly, see output.
  7. No errors reported.

@whizzosoftware
Copy link
Owner Author

Thanks for running the tests and providing logs. It looks like the transaction timeout extension code is doing what it should. I will need to dig into the other errors to see if they are related to this issue or not.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants