-
Notifications
You must be signed in to change notification settings - Fork 22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Extend transaction timeout when new data is received #24
Comments
@anton-johansson: when you have a chance, could you try the code from branch issue-24 to see if you can reproduce the issue you reported in #18? The branch contains fixes for both #24 and #25. Thanks! |
I will take a look when I get home from work, later today! |
Okay, so I did some runs with the changes in branch |
Thanks for running the tests and providing logs. It looks like the transaction timeout extension code is doing what it should. I will need to dig into the other errors to see if they are related to this issue or not. |
When WZWave starts a transaction, it sets the timeout to be an absolute number of seconds from the point that data is sent. There has been cases where seriously slow responses are partially received but the transaction times out before the complete response can be sent.
Ideally, the transaction timeout should be extended when partial data is received to compensate for slow data coming from the PC controller.
The text was updated successfully, but these errors were encountered: