Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(Button): classic variant outline in dark mode #156

Merged
merged 1 commit into from
Apr 29, 2024
Merged

fix(Button): classic variant outline in dark mode #156

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions packages/frosted-ui/.storybook/stories/components/button.stories.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,8 +16,8 @@ const ExampleIcon = () => (
<path
d="M3 2.5C3 2.22386 3.22386 2 3.5 2H11.5C11.7761 2 12 2.22386 12 2.5V13.5C12 13.6818 11.9014 13.8492 11.7424 13.9373C11.5834 14.0254 11.3891 14.0203 11.235 13.924L7.5 11.5896L3.765 13.924C3.61087 14.0203 3.41659 14.0254 3.25762 13.9373C3.09864 13.8492 3 13.6818 3 13.5V2.5ZM4 3V12.5979L6.97 10.7416C7.29427 10.539 7.70573 10.539 8.03 10.7416L11 12.5979V3H4Z"
fill="currentColor"
fill-rule="evenodd"
clip-rule="evenodd"
fillRule="evenodd"
clipRule="evenodd"
></path>
</svg>
);
Expand Down
12 changes: 3 additions & 9 deletions packages/frosted-ui/src/components/base-button.css
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -80,16 +80,10 @@
position: relative;
z-index: 0;

/* prettier-ignore */
box-shadow:
var(--base-button-classic-box-shadow-top),
inset 0 0 0 1px var(--accent-9),
var(--base-button-classic-box-shadow-bottom);

box-shadow:
/* highlight*/
0px 1px 1px 1px var(--white-a5) inset,
/* border color */ 0 0 0 1px var(--accent-a9) inset,
/* border color */
0 0 0 1px var(--accent-a5) inset,
/* highlight*/ 0px 1px 1px 1px var(--white-a5) inset,
/* shadow */ 0px -1px 1px 1px var(--black-a5) inset,
/* drop shadow */ 0px 2px 2px 0px var(--black-a3);

Expand Down
Loading